LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters
Date: Wed, 4 Aug 2021 10:59:30 +0300 [thread overview]
Message-ID: <20210804075930.GD1931@kadam> (raw)
In-Reply-To: <20210730181452.23062-1-fmdefrancesco@gmail.com>
On Fri, Jul 30, 2021 at 08:14:52PM +0200, Fabio M. De Francesco wrote:
> static inline void __nat25_generate_ipx_network_addr_with_socket(unsigned char *networkAddr,
> - unsigned int *ipxNetAddr, unsigned short *ipxSocketAddr)
> + __be32 *ipxNetAddr, __be16 *ipxSocketAddr)
> {
> + union {
> + unsigned int f0;
> + unsigned char f1[4];
> + } addr;
> +
> memset(networkAddr, 0, MAX_NETWORK_ADDR_LEN);
>
> networkAddr[0] = NAT25_IPX;
> - memcpy(networkAddr+1, (unsigned char *)ipxNetAddr, 4);
> - memcpy(networkAddr+5, (unsigned char *)ipxSocketAddr, 2);
> + addr.f0 = be32_to_cpu(*ipxNetAddr);
> + memcpy(networkAddr+1, addr.f1, 4);
> + addr.f0 ^= addr.f0;
> + addr.f0 = be16_to_cpu(*ipxSocketAddr);
> + memcpy(networkAddr+5, addr.f1, 2);
Here is another bug which was obscured/caused by the union.
addr.f0 = be16_to_cpu(*ipxSocketAddr);
The addr.f0 variable is an int. On big endian systems only the last two
bytes are set:
memcpy(networkAddr+5, addr.f1, 2);
So this is the equivalent of:
memset(networkAddr+5, 0, 2);
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-04 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 18:14 Fabio M. De Francesco
2021-08-02 14:05 ` Dan Carpenter
2021-08-02 14:26 ` Fabio M. De Francesco
2021-08-02 15:21 ` Fabio M. De Francesco
2021-08-03 8:15 ` Fabio M. De Francesco
2021-08-03 14:01 ` Dan Carpenter
2021-08-04 7:59 ` Dan Carpenter [this message]
2021-08-04 9:00 ` Fabio M. De Francesco
2021-08-04 9:58 ` Dan Carpenter
2021-08-04 11:29 ` Fabio M. De Francesco
2021-08-04 12:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804075930.GD1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--subject='Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).