LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [bvanassche:scsi-remove-request-pointer 52/52] drivers/scsi/ufs/ufshpb.c:73:19: error: 'struct scsi_cmnd' has no member named 'request'
Date: Wed, 4 Aug 2021 15:51:11 +0800	[thread overview]
Message-ID: <202108041507.SzMwHVau-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 6092 bytes --]

tree:   https://github.com/bvanassche/linux scsi-remove-request-pointer
head:   b6cea39fd8549959686de488ab939cab5601034f
commit: b6cea39fd8549959686de488ab939cab5601034f [52/52] core: Remove the request member from struct scsi_cmnd
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/bvanassche/linux/commit/b6cea39fd8549959686de488ab939cab5601034f
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche scsi-remove-request-pointer
        git checkout b6cea39fd8549959686de488ab939cab5601034f
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/writeback.h:13,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from include/linux/regulator/consumer.h:35,
                    from drivers/scsi/ufs/ufshcd.h:32,
                    from drivers/scsi/ufs/ufshpb.c:15:
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_is_read_cmd':
>> drivers/scsi/ufs/ufshpb.c:73:19: error: 'struct scsi_cmnd' has no member named 'request'
      73 |  return req_op(cmd->request) == REQ_OP_READ;
         |                   ^~
   include/linux/blk_types.h:437:4: note: in definition of macro 'req_op'
     437 |  ((req)->cmd_flags & REQ_OP_MASK)
         |    ^~~
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_is_write_or_discard':
   drivers/scsi/ufs/ufshpb.c:78:31: error: 'struct scsi_cmnd' has no member named 'request'
      78 |  return op_is_write(req_op(cmd->request)) ||
         |                               ^~
   include/linux/blk_types.h:437:4: note: in definition of macro 'req_op'
     437 |  ((req)->cmd_flags & REQ_OP_MASK)
         |    ^~~
   drivers/scsi/ufs/ufshpb.c:79:33: error: 'struct scsi_cmnd' has no member named 'request'
      79 |         op_is_discard(req_op(cmd->request));
         |                                 ^~
   include/linux/blk_types.h:437:4: note: in definition of macro 'req_op'
     437 |  ((req)->cmd_flags & REQ_OP_MASK)
         |    ^~~
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_execute_pre_req':
   drivers/scsi/ufs/ufshpb.c:515:25: error: 'struct scsi_cmnd' has no member named 'request'
     515 |           blk_rq_pos(cmd->request));
         |                         ^~
   drivers/scsi/ufs/ufshpb.c:517:29: error: 'struct scsi_cmnd' has no member named 'request'
     517 |           blk_rq_sectors(cmd->request));
         |                             ^~
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_prep':
   drivers/scsi/ufs/ufshpb.c:615:31: error: 'struct scsi_cmnd' has no member named 'request'
     615 |  if (blk_rq_is_passthrough(cmd->request) ||
         |                               ^~
   drivers/scsi/ufs/ufshpb.c:621:26: error: 'struct scsi_cmnd' has no member named 'request'
     621 |        blk_rq_sectors(cmd->request));
         |                          ^~
   drivers/scsi/ufs/ufshpb.c:625:54: error: 'struct scsi_cmnd' has no member named 'request'
     625 |  lpn = sectors_to_logical(cmd->device, blk_rq_pos(cmd->request));
         |                                                      ^~
   drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_is_write_or_discard':
   drivers/scsi/ufs/ufshpb.c:80:1: error: control reaches end of non-void function [-Werror=return-type]
      80 | }
         | ^
   cc1: some warnings being treated as errors
--
   drivers/scsi/storvsc_drv.c: In function 'storvsc_next_request_id':
>> drivers/scsi/storvsc_drv.c:713:44: error: 'struct scsi_cmnd' has no member named 'request'
     713 |  return (u64)blk_mq_unique_tag(request->cmd->request) + 1;
         |                                            ^~
   In file included from include/linux/device.h:15,
                    from drivers/scsi/storvsc_drv.c:21:
   drivers/scsi/storvsc_drv.c: In function 'storvsc_on_io_completion':
   drivers/scsi/storvsc_drv.c:1205:16: error: 'struct scsi_cmnd' has no member named 'request'
    1205 |    request->cmd->request->tag,
         |                ^~
   include/linux/dev_printk.h:114:33: note: in definition of macro 'dev_warn'
     114 |  _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                 ^~~~~~~~~~~
   drivers/scsi/storvsc_drv.c:1203:3: note: in expansion of macro 'storvsc_log'
    1203 |   storvsc_log(device, STORVSC_LOGGING_ERROR,
         |   ^~~~~~~~~~~
   drivers/scsi/storvsc_drv.c: In function 'storvsc_next_request_id':
   drivers/scsi/storvsc_drv.c:714:1: error: control reaches end of non-void function [-Werror=return-type]
     714 | }
         | ^
   cc1: some warnings being treated as errors
--
   drivers/infiniband/ulp/srp/ib_srp.c: In function 'srp_terminate_cmd':
>> drivers/infiniband/ulp/srp/ib_srp.c:1283:35: error: 'struct scsi_cmnd' has no member named 'request'
    1283 |  u32 tag = blk_mq_unique_tag(scmnd->request);
         |                                   ^~


vim +73 drivers/scsi/ufs/ufshpb.c

2fff76f87542fa Daejun Park 2021-07-12  70  
2fff76f87542fa Daejun Park 2021-07-12  71  static bool ufshpb_is_read_cmd(struct scsi_cmnd *cmd)
2fff76f87542fa Daejun Park 2021-07-12  72  {
2fff76f87542fa Daejun Park 2021-07-12 @73  	return req_op(cmd->request) == REQ_OP_READ;
2fff76f87542fa Daejun Park 2021-07-12  74  }
2fff76f87542fa Daejun Park 2021-07-12  75  

:::::: The code at line 73 was first introduced by commit
:::::: 2fff76f87542fae2366448ec8b01dbff415a7d22 scsi: ufs: ufshpb: Prepare HPB read for cached sub-region

:::::: TO: Daejun Park <daejun7.park@samsung.com>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65169 bytes --]

                 reply	other threads:[~2021-08-04  7:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108041507.SzMwHVau-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bvanassche@acm.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [bvanassche:scsi-remove-request-pointer 52/52] drivers/scsi/ufs/ufshpb.c:73:19: error: '\''struct scsi_cmnd'\'' has no member named '\''request'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).