LKML Archive on
help / color / mirror / Atom feed
From: Kuppuswamy Sathyanarayanan  <>
To: Thomas Gleixner <>,
	Ingo Molnar <>, Borislav Petkov <>,
	Peter Zijlstra <>,
	Andy Lutomirski <>
Cc: Peter H Anvin <>,
	Dave Hansen <>,
	Tony Luck <>,
	Dan Williams <>,
	Andi Kleen <>,
	Kirill Shutemov <>,
	Sean Christopherson <>,
	Kuppuswamy Sathyanarayanan <>,,
Subject: [PATCH v4 5/5] x86: Skip WBINVD instruction for VM guest
Date: Wed,  4 Aug 2021 12:27:28 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

VM guests that supports ACPI, use standard ACPI mechanisms to signal
sleep state entry (including reboot) to the host. The ACPI
specification mandates WBINVD on any sleep state entry with the
expectation that the platform is only responsible for maintaining the
state of memory over sleep states, not preserving dirty data in any
CPU caches. ACPI cache flushing requirements pre-date the advent of
virtualization. Given guest sleep state entry does not affect any
host power rails it is not required to flush caches. The host is
responsible for maintaining cache state over its own bare metal sleep
state transitions that power-off the cache. A TDX guest, unlike a
typical guest, will machine check if the CPU cache is powered off.

Cc: Rafael J. Wysocki <>
Reviewed-by: Dan Williams <>
Acked-by: Rafael J. Wysocki <>
Signed-off-by: Kuppuswamy Sathyanarayanan <>

Changes since v3:
 * None

 arch/x86/include/asm/acenv.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/acenv.h b/arch/x86/include/asm/acenv.h
index 9aff97f0de7f..d4162e94bee8 100644
--- a/arch/x86/include/asm/acenv.h
+++ b/arch/x86/include/asm/acenv.h
@@ -10,10 +10,15 @@
 #define _ASM_X86_ACENV_H
 #include <asm/special_insns.h>
+#include <asm/cpu.h>
 /* Asm macros */
-#define ACPI_FLUSH_CPU_CACHE()	wbinvd()
+#define ACPI_FLUSH_CPU_CACHE()				\
+do {							\
+	if (!boot_cpu_has(X86_FEATURE_HYPERVISOR))	\
+		wbinvd();				\
+} while (0)
 int __acpi_acquire_global_lock(unsigned int *lock);
 int __acpi_release_global_lock(unsigned int *lock);

      parent reply	other threads:[~2021-08-04 19:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 19:27 [PATCH v4 0/5] Add TDX Guest Support (boot fixes) Kuppuswamy Sathyanarayanan
2021-08-04 19:27 ` [PATCH v4 1/5] x86/boot: Add a trampoline for APs booting in 64-bit mode Kuppuswamy Sathyanarayanan
2021-08-04 19:27 ` [PATCH v4 2/5] x86/boot: Avoid #VE during boot for TDX platforms Kuppuswamy Sathyanarayanan
2021-08-04 19:27 ` [PATCH v4 3/5] x86/topology: Disable CPU online/offline control for TDX guest Kuppuswamy Sathyanarayanan
2021-08-04 19:27 ` [PATCH v4 4/5] x86/tdx: Forcefully disable legacy PIC for TDX guests Kuppuswamy Sathyanarayanan
2021-08-04 19:27 ` Kuppuswamy Sathyanarayanan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4 5/5] x86: Skip WBINVD instruction for VM guest' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).