LKML Archive on
help / color / mirror / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	Jason Ekstrand <>,
	Daniel Vetter <>,
	Rodrigo Vivi <>,
	Jani Nikula <>,
	Joonas Lahtinen <>,,
Subject: [PATCH -next] drm/i915: fix i915_globals_exit() section mismatch error
Date: Wed,  4 Aug 2021 13:41:47 -0700	[thread overview]
Message-ID: <> (raw)

Fix modpost Section mismatch error in i915_globals_exit().
Since both an __init function and an __exit function can call
i915_globals_exit(), any function that i915_globals_exit() calls
should not be marked as __init or __exit. I.e., it needs to be
available for either of them.

WARNING: modpost: vmlinux.o(.text+0x8b796a): Section mismatch in reference from the function i915_globals_exit() to the function .exit.text:__i915_globals_flush()
The function i915_globals_exit() references a function in an exit section.
Often the function __i915_globals_flush() has valid usage outside the exit section
and the fix is to remove the __exit annotation of __i915_globals_flush.

ERROR: modpost: Section mismatches detected.

Fixes: 1354d830cb8f ("drm/i915: Call i915_globals_exit() if pci_register_device() fails")
Signed-off-by: Randy Dunlap <>
Cc: Jason Ekstrand <>
Cc: Daniel Vetter <>
Cc: Rodrigo Vivi <>
Cc: Jani Nikula <>
Cc: Joonas Lahtinen <>
 drivers/gpu/drm/i915/i915_globals.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linext-2021-0804.orig/drivers/gpu/drm/i915/i915_globals.c
+++ linext-2021-0804/drivers/gpu/drm/i915/i915_globals.c
@@ -138,7 +138,7 @@ void i915_globals_unpark(void)
-static void __exit __i915_globals_flush(void)
+static void  __i915_globals_flush(void)
 	atomic_inc(&active); /* skip shrinking */

             reply	other threads:[~2021-08-04 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 20:41 Randy Dunlap [this message]
2021-08-04 21:03 ` Jason Ekstrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH -next] drm/i915: fix i915_globals_exit() section mismatch error' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).