LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c
@ 2021-08-05  6:19 cgel.zte
  2021-08-24 14:40 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-08-05  6:19 UTC (permalink / raw)
  To: chris.hyser; +Cc: shuah, yong.yiran, linux-kselftest, linux-kernel, Zeal Robot

From: yong yiran <yong.yiran@zte.com.cn>

'sys/types.h' included in 'cs_prctl_test.c' is duplicated.
Remove all but the first include of sys/types.h from cs_prctl_test.c.

'sys/wait.h' include in 'cs_prctl_test.c' is duplicated.
Remove all but the first include of sys/wait.h from cs_prctl_test.c.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
---
 tools/testing/selftests/sched/cs_prctl_test.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
index 63fe6521c56d..7db9cf822dc7 100644
--- a/tools/testing/selftests/sched/cs_prctl_test.c
+++ b/tools/testing/selftests/sched/cs_prctl_test.c
@@ -25,8 +25,6 @@
 #include <sys/types.h>
 #include <sched.h>
 #include <sys/prctl.h>
-#include <sys/types.h>
-#include <sys/wait.h>
 #include <unistd.h>
 #include <time.h>
 #include <stdio.h>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c
  2021-08-05  6:19 [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c cgel.zte
@ 2021-08-24 14:40 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2021-08-24 14:40 UTC (permalink / raw)
  To: cgel.zte, chris.hyser
  Cc: shuah, yong.yiran, linux-kselftest, linux-kernel, Zeal Robot, Shuah Khan

On 8/5/21 12:19 AM, cgel.zte@gmail.com wrote:
> From: yong yiran <yong.yiran@zte.com.cn>
> 
> 'sys/types.h' included in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/types.h from cs_prctl_test.c.
> 
> 'sys/wait.h' include in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/wait.h from cs_prctl_test.c.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
> ---
>   tools/testing/selftests/sched/cs_prctl_test.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
> index 63fe6521c56d..7db9cf822dc7 100644
> --- a/tools/testing/selftests/sched/cs_prctl_test.c
> +++ b/tools/testing/selftests/sched/cs_prctl_test.c
> @@ -25,8 +25,6 @@
>   #include <sys/types.h>
>   #include <sched.h>
>   #include <sys/prctl.h>
> -#include <sys/types.h>
> -#include <sys/wait.h>
>   #include <unistd.h>
>   #include <time.h>
>   #include <stdio.h>
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-24 14:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05  6:19 [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c cgel.zte
2021-08-24 14:40 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).