LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	Ben Hutchings <ben.hutchings@essensium.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-omap@vger.kernel.org>, Lokesh Vutla <lokeshvutla@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [PATCH net-next 1/3] net: ethernet: ti: cpsw: switch to use skb_put_padto()
Date: Thu, 5 Aug 2021 17:55:53 +0300	[thread overview]
Message-ID: <20210805145555.12182-2-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20210805145555.12182-1-grygorii.strashko@ti.com>

Use skb_put_padto() instead of skb_padto() so skb->len also got updated, as
preparation for further removing frame padding from cpdma.
It also makes xmit path more clear and linear.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/net/ethernet/ti/cpsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index abf9a2a6f7eb..8e1e582a10c8 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -905,7 +905,7 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb,
 	struct cpdma_chan *txch;
 	int ret, q_idx;
 
-	if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) {
+	if (skb_put_padto(skb, CPSW_MIN_PACKET_SIZE)) {
 		cpsw_err(priv, tx_err, "packet pad failed\n");
 		ndev->stats.tx_dropped++;
 		return NET_XMIT_DROP;
-- 
2.17.1


  reply	other threads:[~2021-08-05 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 14:55 [PATCH net-next 0/3] net: ethernet: ti: cpsw/emac: " Grygorii Strashko
2021-08-05 14:55 ` Grygorii Strashko [this message]
2021-08-05 14:55 ` [PATCH net-next 2/3] net: ethernet: ti: davinci_emac: " Grygorii Strashko
2021-08-05 14:55 ` [PATCH net-next 3/3] net: ethernet: ti: davinci_cpdma: drop frame padding Grygorii Strashko
2021-08-06  9:30 ` [PATCH net-next 0/3] net: ethernet: ti: cpsw/emac: switch to use skb_put_padto() patchwork-bot+netdevbpf
2021-08-06 10:00   ` Grygorii Strashko
2021-08-06 10:04     ` David Miller
2021-08-06 10:07       ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805145555.12182-2-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=ben.hutchings@essensium.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --subject='Re: [PATCH net-next 1/3] net: ethernet: ti: cpsw: switch to use skb_put_padto()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).