LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kai Ye <yekai13@huawei.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	wangzhou1@hisilicon.com
Subject: Re: [PATCH 3/5] crypto: hisilicon/sec - fix the max length of AAD for the CCM mode
Date: Fri, 6 Aug 2021 16:32:23 +0800	[thread overview]
Message-ID: <20210806083223.GB13132@gondor.apana.org.au> (raw)
In-Reply-To: <1627701996-4589-4-git-send-email-yekai13@huawei.com>

On Sat, Jul 31, 2021 at 11:26:34AM +0800, Kai Ye wrote:
>
> @@ -2218,6 +2219,10 @@ static int sec_aead_spec_check(struct sec_ctx *ctx, struct sec_req *sreq)
>  	}
>  
>  	if (c_mode == SEC_CMODE_CCM) {
> +		if (unlikely(req->assoclen > SEC_MAX_CCM_AAD_LEN)) {
> +			dev_err(dev, "CCM input aad parameter is too long!\n");
> +			return -EINVAL;
> +		}

You shouldn't be printing messages on a code path that can be
triggered by userspace without rate limit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2021-08-06  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  3:26 [PATCH 0/5] crypto: hisilicon - some misc bugfix for SEC engine Kai Ye
2021-07-31  3:26 ` [PATCH 1/5] crypto: hisilicon/sec - fixup icv checking enabled on Kunpeng 930 Kai Ye
2021-07-31  3:26 ` [PATCH 2/5] crypto: hisilicon/sec - delete the print of fallback tfm application failure Kai Ye
2021-08-06  8:31   ` Herbert Xu
2021-07-31  3:26 ` [PATCH 3/5] crypto: hisilicon/sec - fix the max length of AAD for the CCM mode Kai Ye
2021-08-06  8:32   ` Herbert Xu [this message]
2021-07-31  3:26 ` [PATCH 4/5] crypto: hisilicon/sec - fix the CTR mode BD configuration Kai Ye
2021-07-31  3:26 ` [PATCH 5/5] crypto: hisilicon/sec - use the correct print format Kai Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806083223.GB13132@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=yekai13@huawei.com \
    --subject='Re: [PATCH 3/5] crypto: hisilicon/sec - fix the max length of AAD for the CCM mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).