LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: sbs-battery: add support for time_to_empty_now attribute
Date: Fri, 6 Aug 2021 23:50:50 +0200	[thread overview]
Message-ID: <20210806215050.3pgcqwtcsg22de7c@earth.universe> (raw)
In-Reply-To: <7238b56cca93c8101288b069fd044024da81db1f.1626678985.git.matthias.schiffer@ew.tq-group.com>

[-- Attachment #1: Type: text/plain, Size: 2778 bytes --]

Hi,

On Mon, Jul 19, 2021 at 09:20:19AM +0200, Matthias Schiffer wrote:
> As defined by the Smart Battery Data Specification.
> 
> An _AVG suffix is added to the enum values REG_TIME_TO_EMPTY and
> REG_TIME_TO_FULL to make the distinction clear.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/sbs-battery.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
> index 3d6b8247d450..c4a95b01463a 100644
> --- a/drivers/power/supply/sbs-battery.c
> +++ b/drivers/power/supply/sbs-battery.c
> @@ -31,8 +31,9 @@ enum {
>  	REG_CURRENT_AVG,
>  	REG_MAX_ERR,
>  	REG_CAPACITY,
> -	REG_TIME_TO_EMPTY,
> -	REG_TIME_TO_FULL,
> +	REG_TIME_TO_EMPTY_NOW,
> +	REG_TIME_TO_EMPTY_AVG,
> +	REG_TIME_TO_FULL_AVG,
>  	REG_STATUS,
>  	REG_CAPACITY_LEVEL,
>  	REG_CYCLE_COUNT,
> @@ -119,9 +120,11 @@ static const struct chip_data {
>  		SBS_DATA(POWER_SUPPLY_PROP_ENERGY_FULL, 0x10, 0, 65535),
>  	[REG_FULL_CHARGE_CAPACITY_CHARGE] =
>  		SBS_DATA(POWER_SUPPLY_PROP_CHARGE_FULL, 0x10, 0, 65535),
> -	[REG_TIME_TO_EMPTY] =
> +	[REG_TIME_TO_EMPTY_NOW] =
> +		SBS_DATA(POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, 0x11, 0, 65535),
> +	[REG_TIME_TO_EMPTY_AVG] =
>  		SBS_DATA(POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, 0x12, 0, 65535),
> -	[REG_TIME_TO_FULL] =
> +	[REG_TIME_TO_FULL_AVG] =
>  		SBS_DATA(POWER_SUPPLY_PROP_TIME_TO_FULL_AVG, 0x13, 0, 65535),
>  	[REG_CHARGE_CURRENT] =
>  		SBS_DATA(POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX, 0x14, 0, 65535),
> @@ -165,6 +168,7 @@ static const enum power_supply_property sbs_properties[] = {
>  	POWER_SUPPLY_PROP_CAPACITY,
>  	POWER_SUPPLY_PROP_CAPACITY_ERROR_MARGIN,
>  	POWER_SUPPLY_PROP_TEMP,
> +	POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW,
>  	POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG,
>  	POWER_SUPPLY_PROP_TIME_TO_FULL_AVG,
>  	POWER_SUPPLY_PROP_SERIAL_NUMBER,
> @@ -748,6 +752,7 @@ static void  sbs_unit_adjustment(struct i2c_client *client,
>  		val->intval -= TEMP_KELVIN_TO_CELSIUS;
>  		break;
>  
> +	case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW:
>  	case POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG:
>  	case POWER_SUPPLY_PROP_TIME_TO_FULL_AVG:
>  		/* sbs provides time to empty and time to full in minutes.
> @@ -966,6 +971,7 @@ static int sbs_get_property(struct power_supply *psy,
>  	case POWER_SUPPLY_PROP_CURRENT_NOW:
>  	case POWER_SUPPLY_PROP_CURRENT_AVG:
>  	case POWER_SUPPLY_PROP_TEMP:
> +	case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW:
>  	case POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG:
>  	case POWER_SUPPLY_PROP_TIME_TO_FULL_AVG:
>  	case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-08-06 21:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  7:20 [PATCH 1/2] power: supply: sbs-battery: relax voltage limit Matthias Schiffer
2021-07-19  7:20 ` [PATCH 2/2] power: supply: sbs-battery: add support for time_to_empty_now attribute Matthias Schiffer
2021-08-06 21:50   ` Sebastian Reichel [this message]
2021-08-06 21:50 ` [PATCH 1/2] power: supply: sbs-battery: relax voltage limit Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806215050.3pgcqwtcsg22de7c@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --subject='Re: [PATCH 2/2] power: supply: sbs-battery: add support for time_to_empty_now attribute' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).