LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/3] Cleanups and fixup for memcontrol
@ 2021-08-07  8:28 Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 1/3] mm, memcg: remove unused functions Miaohe Lin
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Miaohe Lin @ 2021-08-07  8:28 UTC (permalink / raw)
  To: hannes, mhocko, vdavydov.dev, akpm, shakeelb, guro, songmuchun
  Cc: willy, alexs, richard.weiyang, linux-mm, linux-kernel, cgroups,
	linmiaohe

Hi all,
This series contains cleanups to remove unused functions, save some
atomic ops and get rid of unneeded lock. More details can be found
in the respective changelogs. Thanks!

Miaohe Lin (3):
  mm, memcg: remove unused functions
  mm, memcg: save some atomic ops when flush is already true
  mm, memcg: get rid of percpu_charge_mutex lock

v1-->v2:
  drop mm, memcg: avoid possible NULL pointer dereferencing in
mem_cgroup_init()
  drop mm, memcg: always call __mod_node_page_state() with preempt
disabled
  collect Reviewed-by and Acked-by tag
  get rid of percpu_charge_mutex instead of narrowing the scope

 include/linux/memcontrol.h | 12 ------------
 mm/memcontrol.c            |  7 +------
 2 files changed, 1 insertion(+), 18 deletions(-)

-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/3] mm, memcg: remove unused functions
  2021-08-07  8:28 [PATCH v2 0/3] Cleanups and fixup for memcontrol Miaohe Lin
@ 2021-08-07  8:28 ` Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 2/3] mm, memcg: save some atomic ops when flush is already true Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock Miaohe Lin
  2 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2021-08-07  8:28 UTC (permalink / raw)
  To: hannes, mhocko, vdavydov.dev, akpm, shakeelb, guro, songmuchun
  Cc: willy, alexs, richard.weiyang, linux-mm, linux-kernel, cgroups,
	linmiaohe

Since commit 2d146aa3aa84 ("mm: memcontrol: switch to rstat"), last user
of memcg_stat_item_in_bytes() is gone. And since commit fa40d1ee9f15 ("mm:
vmscan: memcontrol: remove mem_cgroup_select_victim_node()"), only the
declaration of mem_cgroup_select_victim_node() is remained here. Remove
them.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Roman Gushchin <guro@fb.com>
Acked-by: Michal Hocko <mhocko@suse.com>
---
 include/linux/memcontrol.h | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 7028d8e4a3d7..04437504444f 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -606,13 +606,6 @@ static inline bool PageMemcgKmem(struct page *page)
 	return folio_memcg_kmem(page_folio(page));
 }
 
-static __always_inline bool memcg_stat_item_in_bytes(int idx)
-{
-	if (idx == MEMCG_PERCPU_B)
-		return true;
-	return vmstat_item_in_bytes(idx);
-}
-
 static inline bool mem_cgroup_is_root(struct mem_cgroup *memcg)
 {
 	return (memcg == root_mem_cgroup);
@@ -916,11 +909,6 @@ static inline bool mem_cgroup_online(struct mem_cgroup *memcg)
 	return !!(memcg->css.flags & CSS_ONLINE);
 }
 
-/*
- * For memory reclaim.
- */
-int mem_cgroup_select_victim_node(struct mem_cgroup *memcg);
-
 void mem_cgroup_update_lru_size(struct lruvec *lruvec, enum lru_list lru,
 		int zid, int nr_pages);
 
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] mm, memcg: save some atomic ops when flush is already true
  2021-08-07  8:28 [PATCH v2 0/3] Cleanups and fixup for memcontrol Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 1/3] mm, memcg: remove unused functions Miaohe Lin
@ 2021-08-07  8:28 ` Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock Miaohe Lin
  2 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2021-08-07  8:28 UTC (permalink / raw)
  To: hannes, mhocko, vdavydov.dev, akpm, shakeelb, guro, songmuchun
  Cc: willy, alexs, richard.weiyang, linux-mm, linux-kernel, cgroups,
	linmiaohe

Add 'else' to save some atomic ops in obj_stock_flush_required() when
flush is already true. No functional change intended here.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Roman Gushchin <guro@fb.com>
Acked-by: Michal Hocko <mhocko@suse.com>
---
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6580c2381a3e..7fe242d92802 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2231,7 +2231,7 @@ static void drain_all_stock(struct mem_cgroup *root_memcg)
 		if (memcg && stock->nr_pages &&
 		    mem_cgroup_is_descendant(memcg, root_memcg))
 			flush = true;
-		if (obj_stock_flush_required(stock, root_memcg))
+		else if (obj_stock_flush_required(stock, root_memcg))
 			flush = true;
 		rcu_read_unlock();
 
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock
  2021-08-07  8:28 [PATCH v2 0/3] Cleanups and fixup for memcontrol Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 1/3] mm, memcg: remove unused functions Miaohe Lin
  2021-08-07  8:28 ` [PATCH v2 2/3] mm, memcg: save some atomic ops when flush is already true Miaohe Lin
@ 2021-08-07  8:28 ` Miaohe Lin
  2021-08-07 18:56   ` Andrew Morton
  2 siblings, 1 reply; 6+ messages in thread
From: Miaohe Lin @ 2021-08-07  8:28 UTC (permalink / raw)
  To: hannes, mhocko, vdavydov.dev, akpm, shakeelb, guro, songmuchun
  Cc: willy, alexs, richard.weiyang, linux-mm, linux-kernel, cgroups,
	linmiaohe

We should get rid of percpu_charge_mutex lock as Johannes Weiner said,
""
 It doesn't seem like we need the lock at all.

 The comment says it's so we don't spawn more workers when flushing is
 already underway. But a work cannot be queued more than once - if it
 were just about that, we'd needlessly duplicate the
 test_and_set_bit(WORK_STRUCT_PENDING_BIT) in queue_work_on().

 git history shows we tried to remove it once:

 Commit 8521fc50d433 ("memcg: get rid of percpu_charge_mutex lock")
 tried to do it, but it turned out that the lock did in fact protect
 a data structure: the stock itself. Specifically stock->cached:

 Commit 9f50fad65b87 ("Revert "memcg: get rid of percpu_charge_mutex
 lock"") reverted above removal and explained:

 The patch incorrectly assumes that using atomic FLUSHING_CACHED_CHARGE
 bit operations is sufficient but that is not true.  Johannes Weiner
 has reported a crash during parallel memory cgroup removal:

      BUG: unable to handle kernel NULL pointer dereference at
 0000000000000018
      IP: [<ffffffff81083b70>] css_is_ancestor+0x20/0x70
      Oops: 0000 [#1] PREEMPT SMP
      Pid: 19677, comm: rmdir Tainted: G        W
3.0.0-mm1-00188-gf38d32b #35 ECS MCP61M-M3/MCP61M-M3
      RIP: 0010:[<ffffffff81083b70>]  css_is_ancestor+0x20/0x70
      RSP: 0018:ffff880077b09c88  EFLAGS: 00010202
      Process rmdir (pid: 19677, threadinfo ffff880077b08000, task
ffff8800781bb310)
      Call Trace:
       [<ffffffff810feba3>] mem_cgroup_same_or_subtree+0x33/0x40
       [<ffffffff810feccf>] drain_all_stock+0x11f/0x170
       [<ffffffff81103211>] mem_cgroup_force_empty+0x231/0x6d0
       [<ffffffff811036c4>] mem_cgroup_pre_destroy+0x14/0x20
       [<ffffffff81080559>] cgroup_rmdir+0xb9/0x500
       [<ffffffff81114d26>] vfs_rmdir+0x86/0xe0
       [<ffffffff81114e7b>] do_rmdir+0xfb/0x110
       [<ffffffff81114ea6>] sys_rmdir+0x16/0x20
       [<ffffffff8154d76b>] system_call_fastpath+0x16/0x1b

 We are crashing because we try to dereference cached memcg when we are
 checking whether we should wait for draining on the cache.  The cache
 is already cleaned up, though.

 There is also a theoretical chance that the cached memcg gets freed
 between we test for the FLUSHING_CACHED_CHARGE and dereference it in
 mem_cgroup_same_or_subtree:

            CPU0                    CPU1                         CPU2
      mem=stock->cached
      stock->cached=NULL
                                  clear_bit
                                                           test_and_set_bit
      test_bit()                    ...
      <preempted>             mem_cgroup_destroy
      use after free

 The percpu_charge_mutex protected from this race because sync
 draining is exclusive.

 It is safer to revert now and come up with a more parallel
 implementation later.

 I didn't remember this one at all!

 However, when you look at the codebase from back then, there was no
 rcu-protection for memcg lifetime, and drain_stock() didn't double
 check stock->cached inside the work. Hence the crash during a race.

 The drain code is different now: drain_local_stock() disables IRQs
 which holds up rcu, and then calls drain_stock() and drain_obj_stock()
 which both check stock->cached one more time before the deref.

 With workqueue managing concurrency, and rcu ensuring memcg lifetime
 during the drain, this lock indeed seems unnecessary now.

 Unless I'm missing something, it should just be removed instead.
""

The quote is slightly modified to pass the checkpatch. Please see
https://lore.kernel.org/linux-mm/YQlPiLY0ieRb704V@cmpxchg.org/
for unmodified version.

Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memcontrol.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 7fe242d92802..711f1f60faa2 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2050,7 +2050,6 @@ struct memcg_stock_pcp {
 #define FLUSHING_CACHED_CHARGE	0
 };
 static DEFINE_PER_CPU(struct memcg_stock_pcp, memcg_stock);
-static DEFINE_MUTEX(percpu_charge_mutex);
 
 #ifdef CONFIG_MEMCG_KMEM
 static void drain_obj_stock(struct obj_stock *stock);
@@ -2211,9 +2210,6 @@ static void drain_all_stock(struct mem_cgroup *root_memcg)
 {
 	int cpu, curcpu;
 
-	/* If someone's already draining, avoid adding running more workers. */
-	if (!mutex_trylock(&percpu_charge_mutex))
-		return;
 	/*
 	 * Notify other cpus that system-wide "drain" is running
 	 * We do not care about races with the cpu hotplug because cpu down
@@ -2244,7 +2240,6 @@ static void drain_all_stock(struct mem_cgroup *root_memcg)
 		}
 	}
 	put_cpu();
-	mutex_unlock(&percpu_charge_mutex);
 }
 
 static int memcg_hotplug_cpu_dead(unsigned int cpu)
-- 
2.23.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock
  2021-08-07  8:28 ` [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock Miaohe Lin
@ 2021-08-07 18:56   ` Andrew Morton
  2021-08-09  1:56     ` Miaohe Lin
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2021-08-07 18:56 UTC (permalink / raw)
  To: Miaohe Lin
  Cc: hannes, mhocko, vdavydov.dev, shakeelb, guro, songmuchun, willy,
	alexs, richard.weiyang, linux-mm, linux-kernel, cgroups

On Sat, 7 Aug 2021 16:28:35 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> We should get rid of percpu_charge_mutex lock as Johannes Weiner said,

I'll skip this one for now - it all seems rather uncertain.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock
  2021-08-07 18:56   ` Andrew Morton
@ 2021-08-09  1:56     ` Miaohe Lin
  0 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2021-08-09  1:56 UTC (permalink / raw)
  To: Andrew Morton
  Cc: hannes, mhocko, vdavydov.dev, shakeelb, guro, songmuchun, willy,
	alexs, richard.weiyang, linux-mm, linux-kernel, cgroups

On 2021/8/8 2:56, Andrew Morton wrote:
> On Sat, 7 Aug 2021 16:28:35 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> 
>> We should get rid of percpu_charge_mutex lock as Johannes Weiner said,
> 
> I'll skip this one for now - it all seems rather uncertain.

Sure, many thanks for doing this.

> .
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-09  1:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-07  8:28 [PATCH v2 0/3] Cleanups and fixup for memcontrol Miaohe Lin
2021-08-07  8:28 ` [PATCH v2 1/3] mm, memcg: remove unused functions Miaohe Lin
2021-08-07  8:28 ` [PATCH v2 2/3] mm, memcg: save some atomic ops when flush is already true Miaohe Lin
2021-08-07  8:28 ` [PATCH v2 3/3] mm, memcg: get rid of percpu_charge_mutex lock Miaohe Lin
2021-08-07 18:56   ` Andrew Morton
2021-08-09  1:56     ` Miaohe Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).