LKML Archive on
help / color / mirror / Atom feed
From: Derong Liu <>
To: Chaotian Jing <>,
	Ulf Hansson <>,
	Matthias Brugger <>
Cc: <>,
	<>, <>,
	Peng Zhou <>,
	Derong Liu <>
Subject: [PATCH v2] mmc: mediatek: add wait dma stop done flow
Date: Mon, 9 Aug 2021 15:23:16 +0800	[thread overview]
Message-ID: <> (raw)

We found this issue on a 5G platform, during CMDQ error handling, if DMA status is active when it call msdc_reset_hw, it means mmc host hw reset and DMA transfer will be parallel, mmc host may access sram region unexpectedly.

According to the programming guide of mtk mmc host,it needs to wait for dma stop done after set dma stop.
This change should be applied to all SoCs.

Signed-off-by: Derong Liu <>
 drivers/mmc/host/mtk-sd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 4dfc246c5f95..1dfd2842471b 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2339,6 +2339,8 @@ static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
 	if (recovery) {
 		sdr_set_field(host->base + MSDC_DMA_CTRL,
 			      MSDC_DMA_CTRL_STOP, 1);
+		while (readl(host->base + MSDC_DMA_CFG) & MSDC_DMA_CFG_STS)
+			cpu_relax();

             reply	other threads:[~2021-08-09  7:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  7:23 Derong Liu [this message]
2021-08-16 10:27 ` [PATCH v2] mmc: mediatek: add wait dma stop done flow Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).