LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: 9p: Fix possible null-pointer dereference in p9_cm_event_handler()
@ 2021-08-10 13:20 Tuo Li
  2021-08-10 13:55 ` Leon Romanovsky
  0 siblings, 1 reply; 3+ messages in thread
From: Tuo Li @ 2021-08-10 13:20 UTC (permalink / raw)
  To: ericvh, lucho, asmadeus, davem, kuba
  Cc: v9fs-developer, netdev, linux-kernel, baijiaju1990, Tuo Li, TOTE Robot

The variable rdma is checked when event->event is equal to 
RDMA_CM_EVENT_DISCONNECTED:
  if (rdma)

This indicates that it can be NULL. If so, a null-pointer dereference will 
occur when calling complete():
  complete(&rdma->cm_done);

To fix this possible null-pointer dereference, calling complete() only 
when rdma is not NULL.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
---
 net/9p/trans_rdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index af0a8a6cd3fd..fb3435dfd071 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -285,7 +285,8 @@ p9_cm_event_handler(struct rdma_cm_id *id, struct rdma_cm_event *event)
 	default:
 		BUG();
 	}
-	complete(&rdma->cm_done);
+	if (rdma)
+		complete(&rdma->cm_done);
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-10 14:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 13:20 [PATCH] net: 9p: Fix possible null-pointer dereference in p9_cm_event_handler() Tuo Li
2021-08-10 13:55 ` Leon Romanovsky
2021-08-10 14:20   ` asmadeus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).