From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FA0C432BE for ; Tue, 10 Aug 2021 14:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 741F260EBB for ; Tue, 10 Aug 2021 14:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242940AbhHJOWH (ORCPT ); Tue, 10 Aug 2021 10:22:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:54272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243033AbhHJORl (ORCPT ); Tue, 10 Aug 2021 10:17:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4B0E561101; Tue, 10 Aug 2021 14:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628604995; bh=UJyf+URRaZRGF4EBvF+sX7h0iZKBCnMv8itoRrSVuPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JuRZR7SqczvaBqMfMxIJoTPn0e8VgtiRCB+E9cHqOR9ArtonTaBc9vCcQ1769cFSI HQ6vA5ix6rvytK9VDluVEbYWc01/HsmJ3VKSbVpnw4b59Eadr0YSC9WyNzWTAhrO1U G2BIwSJd3NK3J8QsIdD4cusbRr7SwCJ3r3L28uJ61kvIIyObZmiqdKOtb9loJ/9R0+ ZfIgrgs8rQqlKLceWy7xbSe+gi4m2atTNizzxziHC5mW29Z5n7cAIg6LyBsLKUwRGH 2/7nXUs4OiR+APmAokbN28+Tgqqf8riYc4ulmQnQ6tlMJQkJpAFyPMMykuCvMlEmBJ ljb3YAuvpbMLA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sreekanth Reddy , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 07/11] scsi: core: Avoid printing an error if target_alloc() returns -ENXIO Date: Tue, 10 Aug 2021 10:16:20 -0400 Message-Id: <20210810141625.3118097-7-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210810141625.3118097-1-sashal@kernel.org> References: <20210810141625.3118097-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sreekanth Reddy [ Upstream commit 70edd2e6f652f67d854981fd67f9ad0f1deaea92 ] Avoid printing a 'target allocation failed' error if the driver target_alloc() callback function returns -ENXIO. This return value indicates that the corresponding H:C:T:L entry is empty. Removing this error reduces the scan time if the user issues SCAN_WILD_CARD scan operation through sysfs parameter on a host with a lot of empty H:C:T:L entries. Avoiding the printk on -ENXIO matches the behavior of the other callback functions during scanning. Link: https://lore.kernel.org/r/20210726115402.1936-1-sreekanth.reddy@broadcom.com Signed-off-by: Sreekanth Reddy Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_scan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 009a5b2aa3d0..149465de35b2 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -462,7 +462,8 @@ static struct scsi_target *scsi_alloc_target(struct device *parent, error = shost->hostt->target_alloc(starget); if(error) { - dev_printk(KERN_ERR, dev, "target allocation failed, error %d\n", error); + if (error != -ENXIO) + dev_err(dev, "target allocation failed, error %d\n", error); /* don't want scsi_target_reap to do the final * put because it will be under the host lock */ scsi_target_destroy(starget); -- 2.30.2