LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Robin van der Gracht <robin@protonic.nl>, Miguel Ojeda <ojeda@kernel.org>, Rob Herring <robh+dt@kernel.org>, Paul Burton <paulburton@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH v5 09/19] auxdisplay: ht16k33: Connect backlight to fbdev Date: Wed, 11 Aug 2021 11:57:49 +0200 [thread overview] Message-ID: <20210811095759.1281480-10-geert@linux-m68k.org> (raw) In-Reply-To: <20210811095759.1281480-1-geert@linux-m68k.org> Currently /sys/class/graphics/fb0/bl_curve is not accessible (-ENODEV), as the driver does not connect the backlight to the frame buffer device. Fix this moving backlight initialization up, and filling in fb_info.bl_dev. Fixes: 8992da44c6805d53 ("auxdisplay: ht16k33: Driver for LED controller") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- v5: - No changes, v4: - No changes, v3: - No changes, v2: - New. --- drivers/auxdisplay/ht16k33.c | 56 ++++++++++++++++++------------------ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 1e69cc6d21a0dca2..2b630e194570f6e5 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -413,6 +413,33 @@ static int ht16k33_probe(struct i2c_client *client, if (err) return err; + /* Backlight */ + memset(&bl_props, 0, sizeof(struct backlight_properties)); + bl_props.type = BACKLIGHT_RAW; + bl_props.max_brightness = MAX_BRIGHTNESS; + + bl = devm_backlight_device_register(&client->dev, DRIVER_NAME"-bl", + &client->dev, priv, + &ht16k33_bl_ops, &bl_props); + if (IS_ERR(bl)) { + dev_err(&client->dev, "failed to register backlight\n"); + return PTR_ERR(bl); + } + + err = of_property_read_u32(node, "default-brightness-level", + &dft_brightness); + if (err) { + dft_brightness = MAX_BRIGHTNESS; + } else if (dft_brightness > MAX_BRIGHTNESS) { + dev_warn(&client->dev, + "invalid default brightness level: %u, using %u\n", + dft_brightness, MAX_BRIGHTNESS); + dft_brightness = MAX_BRIGHTNESS; + } + + bl->props.brightness = dft_brightness; + ht16k33_bl_update_status(bl); + /* Framebuffer (2 bytes per column) */ BUILD_BUG_ON(PAGE_SIZE < HT16K33_FB_SIZE); fbdev->buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL); @@ -445,6 +472,7 @@ static int ht16k33_probe(struct i2c_client *client, fbdev->info->screen_size = HT16K33_FB_SIZE; fbdev->info->fix = ht16k33_fb_fix; fbdev->info->var = ht16k33_fb_var; + fbdev->info->bl_dev = bl; fbdev->info->pseudo_palette = NULL; fbdev->info->flags = FBINFO_FLAG_DEFAULT; fbdev->info->par = priv; @@ -460,34 +488,6 @@ static int ht16k33_probe(struct i2c_client *client, goto err_fbdev_unregister; } - /* Backlight */ - memset(&bl_props, 0, sizeof(struct backlight_properties)); - bl_props.type = BACKLIGHT_RAW; - bl_props.max_brightness = MAX_BRIGHTNESS; - - bl = devm_backlight_device_register(&client->dev, DRIVER_NAME"-bl", - &client->dev, priv, - &ht16k33_bl_ops, &bl_props); - if (IS_ERR(bl)) { - dev_err(&client->dev, "failed to register backlight\n"); - err = PTR_ERR(bl); - goto err_fbdev_unregister; - } - - err = of_property_read_u32(node, "default-brightness-level", - &dft_brightness); - if (err) { - dft_brightness = MAX_BRIGHTNESS; - } else if (dft_brightness > MAX_BRIGHTNESS) { - dev_warn(&client->dev, - "invalid default brightness level: %u, using %u\n", - dft_brightness, MAX_BRIGHTNESS); - dft_brightness = MAX_BRIGHTNESS; - } - - bl->props.brightness = dft_brightness; - ht16k33_bl_update_status(bl); - ht16k33_fb_queue(priv); return 0; -- 2.25.1
next prev parent reply other threads:[~2021-08-11 9:58 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 9:57 [PATCH v5 00/19] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 01/19] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 02/19] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 03/19] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 04/19] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 05/19] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 06/19] auxdisplay: Extract character line display core support Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 07/19] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 08/19] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven 2021-08-11 9:57 ` Geert Uytterhoeven [this message] 2021-08-11 9:57 ` [PATCH v5 10/19] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 11/19] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 12/19] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 13/19] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 14/19] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 15/19] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 16/19] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 17/19] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 18/19] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven 2021-08-11 9:57 ` [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven 2021-08-11 10:47 ` Marek Behún 2021-08-11 11:29 ` Geert Uytterhoeven [not found] ` <CAHp75VeNyHUmcU7GPnP8woRcDErDNQ5M3FHQGpLnhUoL5qTnLQ@mail.gmail.com> 2021-08-13 12:52 ` Geert Uytterhoeven 2021-08-13 13:59 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210811095759.1281480-10-geert@linux-m68k.org \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=marek.behun@nic.cz \ --cc=ojeda@kernel.org \ --cc=paulburton@kernel.org \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=robin@protonic.nl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).