LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control
@ 2021-08-11 13:18 Yangtao Li
  2021-08-11 13:18 ` [PATCH 2/2] fs: Don't create discard thread when device not support realtime discard Yangtao Li
  2021-08-11 13:36 ` [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control Chao Yu
  0 siblings, 2 replies; 4+ messages in thread
From: Yangtao Li @ 2021-08-11 13:18 UTC (permalink / raw)
  To: jaegeuk, chao; +Cc: linux-f2fs-devel, linux-kernel, Yangtao Li

Release f2fs_issue_discard every time it is destroyed,
otherwise it will cause memory leaks when remounting.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/segment.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index afe20c5c3c08..363779a4402d 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1741,6 +1741,7 @@ void f2fs_stop_discard_thread(struct f2fs_sb_info *sbi)
 
 		dcc->f2fs_issue_discard = NULL;
 		kthread_stop(discard_thread);
+		put_task_struct(discard_thread);
 	}
 }
 
@@ -2168,6 +2169,7 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
 		SM_I(sbi)->dcc_info = NULL;
 		return err;
 	}
+	get_task_struct(dcc->f2fs_issue_discard);
 
 	return err;
 }
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-11 13:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 13:18 [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control Yangtao Li
2021-08-11 13:18 ` [PATCH 2/2] fs: Don't create discard thread when device not support realtime discard Yangtao Li
2021-08-11 13:44   ` Chao Yu
2021-08-11 13:36 ` [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).