LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nadezda Lutovinova <lutovinova@ispras.ru>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Nadezda Lutovinova <lutovinova@ispras.ru>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver().
Date: Wed, 11 Aug 2021 16:31:42 +0300 [thread overview]
Message-ID: <20210811133142.13363-1-lutovinova@ispras.ru> (raw)
If rcsi2_code_to_fmt() return NULL,
then null pointer dereference occurs in the next cycle.
The patch adds checking if format is NULL.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index e28eff039688..55bb584d2a13 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -553,6 +553,12 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
/* Code is validated in set_fmt. */
format = rcsi2_code_to_fmt(priv->mf.code);
+ if (!format) {
+ dev_err(priv->dev,
+ "Incorrect mbus frame format code %u\n",
+ priv->mf.code);
+ return -EINVAL;
+ }
/*
* Enable all supported CSI-2 channels with virtual channel and
--
2.17.1
next reply other threads:[~2021-08-11 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:31 Nadezda Lutovinova [this message]
2021-08-11 13:45 ` Niklas Söderlund
2021-08-11 17:18 ` [PATCH v2] " Nadezda Lutovinova
2021-08-12 9:16 ` Jacopo Mondi
2021-08-12 9:30 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811133142.13363-1-lutovinova@ispras.ru \
--to=lutovinova@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--subject='Re: [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).