LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: fstests@vger.kernel.org
Cc: hare@suse.de, dgilbert@interlog.com, jeyu@kernel.org,
lucas.demarchi@intel.com, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v2 0/3] fstests: add patient module remover
Date: Wed, 11 Aug 2021 08:45:09 -0700 [thread overview]
Message-ID: <20210811154512.1813622-1-mcgrof@kernel.org> (raw)
This is v2 of my series of enhancements to fstests to deal with
false positives with meta block drivers we use for tests such as
scsi_debug which are caused by races by not being able to remove
a driver.
Changes in v2:
- Now that I have confirmed the issue with the refcnt being bumped
after it becomes 0 is also present on linux-next, and *is* a generic
"this is life with modules" matter, I went ahead and implemented
a patient module remover support into kmod and posted patches.
What this means for this series of patches is that we get a real
patient module remover support in modprobe, and so modprobe -p
will soon be an option, if merged. This series then now checks for
that and if its present uses it, otherwise it open codes a similar
solution.
- The patient module remover now also re-tries to remove the module,
as *any* race can easily bump a module refcnt up. We just then need
an upper limit threshold on timeout or to decide if we run forever.
- adds udevadm settle after pvremove
- I confirm now I don't get any stupid module false positives on older
or newer kernels, and life can move on.
Luis Chamberlain (3):
fstests: use udevadm settle after pvremove
common/module: add patient module rmmod support
common/scsi_debug: use the patient module remover
common/config | 31 ++++++++++++++
common/module | 107 ++++++++++++++++++++++++++++++++++++++++++++++
common/scsi_debug | 6 ++-
tests/generic/081 | 5 ++-
tests/generic/108 | 1 +
tests/generic/459 | 1 +
6 files changed, 148 insertions(+), 3 deletions(-)
--
2.30.2
next reply other threads:[~2021-08-11 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:45 Luis Chamberlain [this message]
2021-08-11 15:45 ` [PATCH v2 1/3] fstests: use udevadm settle after pvremove Luis Chamberlain
2021-08-15 12:36 ` Eryu Guan
2021-08-11 15:45 ` [PATCH v2 2/3] common/module: add patient module rmmod support Luis Chamberlain
2021-08-15 12:29 ` Eryu Guan
2021-08-18 14:02 ` Luis Chamberlain
2021-08-19 2:26 ` Eryu Guan
2021-08-19 23:58 ` Luis Chamberlain
2021-08-11 15:45 ` [PATCH v2 3/3] common/scsi_debug: use the patient module remover Luis Chamberlain
2021-08-15 12:35 ` Eryu Guan
2021-08-20 0:33 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811154512.1813622-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=dgilbert@interlog.com \
--cc=fstests@vger.kernel.org \
--cc=hare@suse.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--subject='Re: [PATCH v2 0/3] fstests: add patient module remover' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).