LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: gregkh@linuxfoundation.org
Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH v2 0/3] staging: r8188eu: Clean up some smatch warnings and errors
Date: Wed, 11 Aug 2021 20:52:29 -0500 [thread overview]
Message-ID: <20210812015232.23784-1-Larry.Finger@lwfinger.net> (raw)
Smatch reports a number of warnings ans a few errors. Most are places where
the indentation is messed up, but a few are unitialized variables or
dereferencing a pointer before checking it.
Smatch does output a false message concerning a potential memory leak.
The pointer is saved, and the memory freed in another routine.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - did a respin of the patches due to conflict
---
Larry Finger (3):
staging: r8188eu: Fix Smatch warnings for core/*.c
staging: r8188eu: Fix smatch problems in hal/*.c
staging: r8188eu: Fix smatch warnings in os_dep/*.c
drivers/staging/r8188eu/core/rtw_br_ext.c | 2 +-
drivers/staging/r8188eu/core/rtw_cmd.c | 6 -
drivers/staging/r8188eu/core/rtw_ieee80211.c | 2 +-
drivers/staging/r8188eu/core/rtw_io.c | 2 +-
drivers/staging/r8188eu/core/rtw_led.c | 20 +--
drivers/staging/r8188eu/core/rtw_mlme.c | 16 ++-
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 16 +--
drivers/staging/r8188eu/core/rtw_mp.c | 6 +-
drivers/staging/r8188eu/core/rtw_p2p.c | 4 +-
drivers/staging/r8188eu/core/rtw_recv.c | 18 +--
drivers/staging/r8188eu/core/rtw_security.c | 6 +-
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 6 +-
drivers/staging/r8188eu/core/rtw_wlan_util.c | 14 +--
drivers/staging/r8188eu/core/rtw_xmit.c | 4 +-
.../r8188eu/hal/Hal8188ERateAdaptive.c | 16 +--
.../staging/r8188eu/hal/HalHWImg8188E_RF.c | 2 +-
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
drivers/staging/r8188eu/hal/odm.c | 18 +--
drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +-
.../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +-
drivers/staging/r8188eu/hal/rtl8188e_mp.c | 8 +-
drivers/staging/r8188eu/hal/usb_halinit.c | 18 +--
drivers/staging/r8188eu/hal/usb_ops_linux.c | 87 +++++++------
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 56 +++++----
drivers/staging/r8188eu/os_dep/mlme_linux.c | 3 +-
drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +-
.../staging/r8188eu/os_dep/osdep_service.c | 2 +-
drivers/staging/r8188eu/os_dep/recv_linux.c | 8 +-
drivers/staging/r8188eu/os_dep/usb_intf.c | 117 +++++++++---------
29 files changed, 226 insertions(+), 239 deletions(-)
--
2.32.0
next reply other threads:[~2021-08-12 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 1:52 Larry Finger [this message]
2021-08-12 1:52 ` [PATCH v2 1/3] staging: r8188eu: Fix Smatch warnings for core/*.c Larry Finger
2021-08-12 1:52 ` [PATCH v2 2/3] staging: r8188eu: Fix smatch problems in hal/*.c Larry Finger
2021-08-12 1:52 ` [PATCH v2 3/3] staging: r8188eu: Fix smatch warnings in os_dep/*.c Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812015232.23784-1-Larry.Finger@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).