LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Paul Davey <paul.davey@alliedtelesis.co.nz> To: Manivannan Sadhasivam <mani@kernel.org> Cc: Hemant Kumar <hemantk@codeaurora.org>, Bhaumik Bhatt <bbhatt@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Davey <paul.davey@alliedtelesis.co.nz> Subject: [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures Date: Thu, 12 Aug 2021 15:16:58 +1200 [thread overview] Message-ID: <20210812031700.23397-1-paul.davey@alliedtelesis.co.nz> (raw) I encountered some problems getting the MHI driver to work on an Octeon 3 platform these seem to all be related to endianness issues. The modem interface appears to require the DMA structures to be in little endian, however the MHI core driver was assembling them in native endianness. Using little endian explicitly allows the interface to function as expected. Changes in v4: - add Fixes and Reviewed-By tags as requested/offered. Changes in v3: - removed change of doorbell helper functions db_val type from dma_addr_t to __le64 favouring doing conversion only when writing to context wp fields. Changes in v2: - use __fls instead of find_last_bit in pm_state conversion patch as requested by Hemant Kumar <hemantk@codeaurora.org> Paul Davey (2): bus: mhi: Fix pm_state conversion to string bus: mhi: Fix MHI DMA structure endianness drivers/bus/mhi/core/debugfs.c | 26 +++---- drivers/bus/mhi/core/init.c | 43 ++++++------ drivers/bus/mhi/core/internal.h | 119 ++++++++++++++++---------------- drivers/bus/mhi/core/main.c | 22 +++--- drivers/bus/mhi/core/pm.c | 4 +- 5 files changed, 109 insertions(+), 105 deletions(-) -- 2.32.0
next reply other threads:[~2021-08-12 3:17 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-12 3:16 Paul Davey [this message] 2021-08-12 3:16 ` [PATCH v4 1/2] bus: mhi: Fix pm_state conversion to string Paul Davey 2021-08-12 3:17 ` [PATCH v4 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey 2022-02-09 7:59 ` [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210812031700.23397-1-paul.davey@alliedtelesis.co.nz \ --to=paul.davey@alliedtelesis.co.nz \ --cc=bbhatt@codeaurora.org \ --cc=hemantk@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mani@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).