LKML Archive on
help / color / mirror / Atom feed
From: Paul Davey <>
To: Manivannan Sadhasivam <>
Cc: Hemant Kumar <>,
	Bhaumik Bhatt <>,,,
	Paul Davey <>,
Subject: [PATCH v4 1/2] bus: mhi: Fix pm_state conversion to string
Date: Thu, 12 Aug 2021 15:16:59 +1200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On big endian architectures the mhi debugfs files which report pm state
give "Invalid State" for all states.  This is caused by using
find_last_bit which takes an unsigned long* while the state is passed in
as an enum mhi_pm_state which will be of int size.

Fix by using __fls to pass the value of state instead of find_last_bit.

Fixes: a6e2e3522f29 ("bus: mhi: core: Add support for PM state transitions")
Reviewed-by: Manivannan Sadhasivam <>
Reviewed-by: Hemant Kumar <>
Signed-off-by: Paul Davey <>
 drivers/bus/mhi/core/init.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 5aaca6d0f52b..0d588b60929e 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -79,9 +79,12 @@ static const char * const mhi_pm_state_str[] = {
 const char *to_mhi_pm_state_str(enum mhi_pm_state state)
-	int index = find_last_bit((unsigned long *)&state, 32);
+	int index;
-	if (index >= ARRAY_SIZE(mhi_pm_state_str))
+	if (state)
+		index = __fls(state);
+	if (!state || index >= ARRAY_SIZE(mhi_pm_state_str))
 		return "Invalid State";
 	return mhi_pm_state_str[index];

  reply	other threads:[~2021-08-12  3:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  3:16 [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-08-12  3:16 ` Paul Davey [this message]
2021-08-12  3:17 ` [PATCH v4 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2022-02-09  7:59 ` [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).