LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME
@ 2021-08-12  8:10 Heinrich Schuchardt
  2021-08-12  8:10 ` [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1 Heinrich Schuchardt
  2021-09-11  6:03 ` [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Palmer Dabbelt
  0 siblings, 2 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-08-12  8:10 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt
  Cc: Albert Ou, Atish Patra, Anup Patel, Heinrich Schuchardt,
	Ard Biesheuvel, Sagar Shrikant Kadam, linux-riscv, linux-kernel,
	Heinrich Schuchardt

NVMe is a non-volatile storage media attached via PCIe.
As NVMe has much higher throughput than other block devices like
SATA it is a must have for RISC-V. Enable CONFIG_BLK_DEV_NVME.

The HiFive Unmatched is a board providing M.2 slots for NVMe drives.
Enable CONFIG_PCIE_FU740.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
resent on Palmer's request due to non-matching e-mail addresses
https://lore.kernel.org/linux-riscv/20210726112511.78350-1-xypron.glpk@gmx.de/
---
 arch/riscv/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 1f2be234b11c..393bf3843e5c 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -39,10 +39,12 @@ CONFIG_PCI=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_PCI_HOST_GENERIC=y
 CONFIG_PCIE_XILINX=y
+CONFIG_PCIE_FU740=y
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_VIRTIO_BLK=y
+CONFIG_BLK_DEV_NVME=m
 CONFIG_BLK_DEV_SD=y
 CONFIG_BLK_DEV_SR=y
 CONFIG_SCSI_VIRTIO=y
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1
  2021-08-12  8:10 [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Heinrich Schuchardt
@ 2021-08-12  8:10 ` Heinrich Schuchardt
  2021-09-11  6:03 ` [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Palmer Dabbelt
  1 sibling, 0 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-08-12  8:10 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt
  Cc: Albert Ou, Atish Patra, Anup Patel, Heinrich Schuchardt,
	Ard Biesheuvel, Sagar Shrikant Kadam, linux-riscv, linux-kernel,
	Heinrich Schuchardt

The EFI system partition uses the FAT file system. Many distributions add
an entry in /etc/fstab for the ESP. We must ensure that mounting does not
fail.

The default code page for FAT is 437 (cf. CONFIG_FAT_DEFAULT_CODEPAGE).
The default IO character set is "iso8859-1" (cf. CONFIG_NLS_ISO8859_1).

So let's enable NLS_CODEPAGE_437 and NLS_ISO8859_1 in defconfig.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
resent on Palmer's request due to non-matching e-mail addresses
cf. https://lore.kernel.org/linux-riscv/20210726112647.78561-1-xypron.glpk@gmx.de/
---
 arch/riscv/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 393bf3843e5c..1a3170d5f203 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -110,6 +110,8 @@ CONFIG_NFS_V4_1=y
 CONFIG_NFS_V4_2=y
 CONFIG_ROOT_NFS=y
 CONFIG_9P_FS=y
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_ISO8859_1=m
 CONFIG_CRYPTO_USER_API_HASH=y
 CONFIG_CRYPTO_DEV_VIRTIO=y
 CONFIG_PRINTK_TIME=y
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME
  2021-08-12  8:10 [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Heinrich Schuchardt
  2021-08-12  8:10 ` [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1 Heinrich Schuchardt
@ 2021-09-11  6:03 ` Palmer Dabbelt
  1 sibling, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2021-09-11  6:03 UTC (permalink / raw)
  To: heinrich.schuchardt
  Cc: Paul Walmsley, aou, Atish Patra, Anup Patel, xypron.glpk, ardb,
	sagar.kadam, linux-riscv, linux-kernel, heinrich.schuchardt

On Thu, 12 Aug 2021 01:10:26 PDT (-0700), heinrich.schuchardt@canonical.com wrote:
> NVMe is a non-volatile storage media attached via PCIe.
> As NVMe has much higher throughput than other block devices like
> SATA it is a must have for RISC-V. Enable CONFIG_BLK_DEV_NVME.
>
> The HiFive Unmatched is a board providing M.2 slots for NVMe drives.
> Enable CONFIG_PCIE_FU740.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> resent on Palmer's request due to non-matching e-mail addresses
> https://lore.kernel.org/linux-riscv/20210726112511.78350-1-xypron.glpk@gmx.de/
> ---
>  arch/riscv/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 1f2be234b11c..393bf3843e5c 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -39,10 +39,12 @@ CONFIG_PCI=y
>  CONFIG_PCIEPORTBUS=y
>  CONFIG_PCI_HOST_GENERIC=y
>  CONFIG_PCIE_XILINX=y
> +CONFIG_PCIE_FU740=y
>  CONFIG_DEVTMPFS=y
>  CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_VIRTIO_BLK=y
> +CONFIG_BLK_DEV_NVME=m
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_BLK_DEV_SR=y
>  CONFIG_SCSI_VIRTIO=y

Thanks, these are on for-next.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1
  2021-07-26 11:26 ` [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1 Heinrich Schuchardt
@ 2021-08-12  7:18   ` Palmer Dabbelt
  0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2021-08-12  7:18 UTC (permalink / raw)
  To: xypron.glpk
  Cc: Paul Walmsley, aou, heinrich.schuchardt, Atish Patra, Anup Patel,
	kernel, sagar.kadam, linux-riscv, linux-kernel, xypron.glpk

On Mon, 26 Jul 2021 04:26:47 PDT (-0700), xypron.glpk@gmx.de wrote:
> The EFI system partition uses the FAT file system. Many distributions add
> an entry in /etc/fstab for the ESP. We must ensure that mounting does not
> fail.
>
> The default code page for FAT is 437 (cf. CONFIG_FAT_DEFAULT_CODEPAGE).
> The default IO character set is "iso8859-1" (cf. CONFIG_NLS_ISO8859_1).
>
> So let's enable NLS_CODEPAGE_437 and NLS_ISO8859_1 in defconfig.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  arch/riscv/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 393bf3843e5c..1a3170d5f203 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -110,6 +110,8 @@ CONFIG_NFS_V4_1=y
>  CONFIG_NFS_V4_2=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_9P_FS=y
> +CONFIG_NLS_CODEPAGE_437=y
> +CONFIG_NLS_ISO8859_1=m
>  CONFIG_CRYPTO_USER_API_HASH=y
>  CONFIG_CRYPTO_DEV_VIRTIO=y
>  CONFIG_PRINTK_TIME=y

These both look fine, but I'm getting checkpatch warnings about the 
Signed-off-by address not matching the From address.  Not sure if it's 
just something wrong on my end, but when I send from a different address 
then I want as the Author field I generally end up with a "From: " line 
at the top of my patch.

I know it's a bit pedantic, but IIUC I'm not supposed to take things 
like tihs.  Do you mind re-sending these as patches that are internally 
consistent?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1
  2021-07-26 11:25 Heinrich Schuchardt
@ 2021-07-26 11:26 ` Heinrich Schuchardt
  2021-08-12  7:18   ` Palmer Dabbelt
  0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-07-26 11:26 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Heinrich Schuchardt, Atish Patra, Anup Patel,
	Emil Renner Berthing, Sagar Shrikant Kadam, linux-riscv,
	linux-kernel, Heinrich Schuchardt

The EFI system partition uses the FAT file system. Many distributions add
an entry in /etc/fstab for the ESP. We must ensure that mounting does not
fail.

The default code page for FAT is 437 (cf. CONFIG_FAT_DEFAULT_CODEPAGE).
The default IO character set is "iso8859-1" (cf. CONFIG_NLS_ISO8859_1).

So let's enable NLS_CODEPAGE_437 and NLS_ISO8859_1 in defconfig.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 arch/riscv/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 393bf3843e5c..1a3170d5f203 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -110,6 +110,8 @@ CONFIG_NFS_V4_1=y
 CONFIG_NFS_V4_2=y
 CONFIG_ROOT_NFS=y
 CONFIG_9P_FS=y
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_ISO8859_1=m
 CONFIG_CRYPTO_USER_API_HASH=y
 CONFIG_CRYPTO_DEV_VIRTIO=y
 CONFIG_PRINTK_TIME=y
--
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-11  6:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12  8:10 [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Heinrich Schuchardt
2021-08-12  8:10 ` [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1 Heinrich Schuchardt
2021-09-11  6:03 ` [PATCH 1/2] riscv: defconfig: enable BLK_DEV_NVME Palmer Dabbelt
  -- strict thread matches above, loose matches on Subject: below --
2021-07-26 11:25 Heinrich Schuchardt
2021-07-26 11:26 ` [PATCH 2/2] riscv: defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1 Heinrich Schuchardt
2021-08-12  7:18   ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).