LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Laibin Qiu <qiulaibin@huawei.com>
To: <axboe@kernel.dk>
Cc: <maco@android.com>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <qiulaibin@huawei.com>
Subject: [PATCH -next] loop: fix loop_validate_block_size() can't make sense
Date: Thu, 12 Aug 2021 16:34:53 +0800 [thread overview]
Message-ID: <20210812083453.761319-1-qiulaibin@huawei.com> (raw)
We config the block size of a loop device throuth
the following process:
lo_ioctl(..., unsigned long arg)
| ^^^^
lo_simple_ioctl(..., unsigned long arg)
| ^^^^
loop_set_block_size(..., unsigned long arg)
| ^^^^
loop_validate_block_size(unsigned short bsize)
| ^^^^^
blk_queue_logical_block_size(..., unsigned int size) {
'''
limits->logical_block_size = size;
^^^^ int
'''
}
loop_validate_block_size() will check the validity of bsize.
But long to short will be truncated(eg arg=1049600 and
it becomes 1024 after truncation by short. The block size
must within the range of 512 ~ PAGE_SZIE, This truncation will
turn illegal block szie to legal). The wrong of block size will
raise other errors.
Fixes: 3448914e8cc55 ("loop: Add LOOP_CONFIGURE ioctl")
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index fa1c298a8cfb..8fd551c00a9b 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -277,7 +277,7 @@ static void __loop_update_dio(struct loop_device *lo, bool dio)
* @bsize: size to validate
*/
static int
-loop_validate_block_size(unsigned short bsize)
+loop_validate_block_size(unsigned long bsize)
{
if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
return -EINVAL;
--
2.22.0
reply other threads:[~2021-08-12 8:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812083453.761319-1-qiulaibin@huawei.com \
--to=qiulaibin@huawei.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--subject='Re: [PATCH -next] loop: fix loop_validate_block_size() can'\''t make sense' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).