LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V4 1/7] mm: memcontrol: add helper of memcg_get_e_css
Date: Thu, 12 Aug 2021 10:58:23 +0200 [thread overview]
Message-ID: <20210812085823.GC2867@lst.de> (raw)
In-Reply-To: <20210806080302.298297-2-ming.lei@redhat.com>
On Fri, Aug 06, 2021 at 04:02:56PM +0800, Ming Lei wrote:
> And helper of memcg_get_e_css() so that the consumer needn't to
> call cgroup_get_e_css(cgroup, &memory_cgrp_subsys) directly, since
> &memory_cgrp_subsys has to be used in case that MEMCG is enabled.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> include/linux/memcontrol.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index bfe5c486f4ad..741852addbd7 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1101,6 +1101,11 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order,
> gfp_t gfp_mask,
> unsigned long *total_scanned);
>
> +static inline
> +struct cgroup_subsys_state *memcg_get_e_css(struct cgroup_subsys_state *css)
Please avoid this totally weird placement of the static and inline
specifiers.
next prev parent reply other threads:[~2021-08-12 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 8:02 [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg Ming Lei
2021-08-06 8:02 ` [PATCH V4 1/7] mm: memcontrol: add helper of memcg_get_e_css Ming Lei
2021-08-12 8:58 ` Christoph Hellwig [this message]
2021-08-06 8:02 ` [PATCH V4 2/7] loop: clean up blkcg association Ming Lei
2021-08-12 8:59 ` Christoph Hellwig
2021-08-06 8:02 ` [PATCH V4 3/7] loop: conver timer for monitoring idle worker into dwork Ming Lei
2021-08-06 8:02 ` [PATCH V4 4/7] loop: add __loop_free_idle_workers() for covering freeing workers in clearing FD Ming Lei
2021-08-06 8:03 ` [PATCH V4 5/7] loop: improve loop_process_work Ming Lei
2021-08-06 8:03 ` [PATCH V4 6/7] loop: use xarray to store workers Ming Lei
2021-08-06 8:03 ` [PATCH V4 7/7] loop: don't add worker into idle list Ming Lei
2021-08-09 6:41 ` [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg Christoph Hellwig
2021-08-10 3:26 ` Ming Lei
2021-08-12 9:00 ` Christoph Hellwig
2021-08-14 9:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812085823.GC2867@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=schatzberg.dan@gmail.com \
--subject='Re: [PATCH V4 1/7] mm: memcontrol: add helper of memcg_get_e_css' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).