From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5889C4320E for ; Thu, 12 Aug 2021 19:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7F8A60C3E for ; Thu, 12 Aug 2021 19:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236938AbhHLTvW (ORCPT ); Thu, 12 Aug 2021 15:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236114AbhHLTvJ (ORCPT ); Thu, 12 Aug 2021 15:51:09 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6340CC0613A3 for ; Thu, 12 Aug 2021 12:50:43 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id k3so8303726ilu.2 for ; Thu, 12 Aug 2021 12:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QSpci64/hMqy88Q22faTec2s8wp9JGPuRuA3v3rI9YQ=; b=P3PRMZs3/UXYGNdQf6SaCtATu/V7phGy1FxQf7KjkvhAxxvjN3hT//M8K4o4ZBQ7Fq 3dHx2dIcLC6jIsftPgWyWs4noXGATMniiRJxxFAbN+j8t+TDnsM0qUHYoiPwh2EVwWo/ ud4rYqKOEe1v1AjP4t4lIJ2aLiAcK90QyRTg5+/+EAwD/DhNv65eQwPX7XPjsJAn3Hnd HPvYsAR4a2STwLpB2581d7NsTAR83QTdTPApN1cOmTWAq78WAkIrlbQytKTiVPEY4q22 QandDbjzdrgMHQyogapKm+tDPg3OG8Ppe80H/y0rLEo/erFfc63hrdVTULUsJnEeMXXF cb+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QSpci64/hMqy88Q22faTec2s8wp9JGPuRuA3v3rI9YQ=; b=eUUCM+nGsuB8LStRxbwWk1blfOFVuux+UAYK+mndqoYFrzDwbSmqd2/4ksAEDfFECU YpzcFRickls3upbxcISkFkFBXZ+YERIMb52lnU8N50EfP7Sr6fu0cF8y7dfaVN7RyWp7 JO0W7ppmCYVAeSlhFLpKV5sub/foY25csSChbBARuNqR/M1K6HsepC8WcUHx4X1lZcG9 M1tYEkVFdXv1pCw2iGOjZ7s27XE00UqUDK2AA9cRz3c9CyE0Zq6azVAPacPBpIOYGLN1 kia4d9DDRlwn5ioNUYJBbf3PCVlWj9hWQzZJAg3VA07H+rz7Hs+rTxDMqszGCsOaLzRV /LPg== X-Gm-Message-State: AOAM532WpVMW9sRthi+NzsjnacZpoLO46TbAoiHBoAVw6gVHXJcZC+rB YhNj0DSXXccnuC6xGF4Ldxixag== X-Google-Smtp-Source: ABdhPJxdTlMj27RouCNABii+wKYviIwvoHaqmPVm9lPO4xCIx7uNnSQbqY0w+GPM1/qc5YTQtlwa6w== X-Received: by 2002:a92:d18c:: with SMTP id z12mr176696ilz.295.1628797842839; Thu, 12 Aug 2021 12:50:42 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id s16sm2058821iln.5.2021.08.12.12.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 12:50:42 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 5/6] net: ipa: don't stop TX on suspend Date: Thu, 12 Aug 2021 14:50:34 -0500 Message-Id: <20210812195035.2816276-6-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210812195035.2816276-1-elder@linaro.org> References: <20210812195035.2816276-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently we stop the modem netdev transmit queue when suspending the hardware. For system suspend this ensured we'd never attempt to transmit while attempting to suspend the modem endpoints. For runtime suspend, the IPA hardware might get suspended while the system is operating. In that case we want an attempt to transmit a packet to cause the hardware to resume if necessary. But if we disable the queue this cannot happen. So stop disabling the queue on suspend. In case we end up disabling it in ipa_start_xmit() (see the previous commit), we still arrange to start the TX queue on resume. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_modem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index aa1b483d9f7db..b176910d72868 100644 --- a/drivers/net/ipa/ipa_modem.c +++ b/drivers/net/ipa/ipa_modem.c @@ -214,8 +214,6 @@ void ipa_modem_suspend(struct net_device *netdev) if (!(netdev->flags & IFF_UP)) return; - netif_stop_queue(netdev); - ipa_endpoint_suspend_one(ipa->name_map[IPA_ENDPOINT_AP_MODEM_RX]); ipa_endpoint_suspend_one(ipa->name_map[IPA_ENDPOINT_AP_MODEM_TX]); } -- 2.27.0