LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] RDMA/rxe: Remove duplicate umem assignment
@ 2021-08-13  5:57 Shunsuke Mie
  2021-08-13 11:30 ` yangx.jy
  0 siblings, 1 reply; 3+ messages in thread
From: Shunsuke Mie @ 2021-08-13  5:57 UTC (permalink / raw)
  To: Zhu Yanjun, Doug Ledford, Jason Gunthorpe; +Cc: mie, linux-rdma, linux-kernel

While initialization of rxe_mr, mr->umem is assigned duplicate. Remove
the redundant code.

Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
---
 drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 73bbafd32554..6e2e0da2e50d 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
 		goto err1;
 	}
 
-	mr->umem = umem;
 	num_buf = ib_umem_num_pages(umem);
 
 	rxe_mr_init(access, mr);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment
  2021-08-13  5:57 [PATCH] RDMA/rxe: Remove duplicate umem assignment Shunsuke Mie
@ 2021-08-13 11:30 ` yangx.jy
  2021-08-16  1:45   ` Shunsuke Mie
  0 siblings, 1 reply; 3+ messages in thread
From: yangx.jy @ 2021-08-13 11:30 UTC (permalink / raw)
  To: Shunsuke Mie
  Cc: Zhu Yanjun, Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel

Hi,

My same fix[1] has been merged into for-next branch on rdma but it is
not merged into mainline for now.

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f

Best Regards,
Xiao Yang

On 2021/8/13 13:57, Shunsuke Mie wrote:
> While initialization of rxe_mr, mr->umem is assigned duplicate. Remove
> the redundant code.
>
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> ---
>  drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 73bbafd32554..6e2e0da2e50d 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
>  		goto err1;
>  	}
>  
> -	mr->umem = umem;
>  	num_buf = ib_umem_num_pages(umem);
>  
>  	rxe_mr_init(access, mr);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment
  2021-08-13 11:30 ` yangx.jy
@ 2021-08-16  1:45   ` Shunsuke Mie
  0 siblings, 0 replies; 3+ messages in thread
From: Shunsuke Mie @ 2021-08-16  1:45 UTC (permalink / raw)
  To: yangx.jy
  Cc: Zhu Yanjun, Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel

HI, Xiao.

> My same fix[1] has been merged into for-next branch on rdma but it is
> not merged into mainline for now.
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f
Thank you for the information. I had missed it.

Thanks a lot,
Shunsuke Mie

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-16  1:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13  5:57 [PATCH] RDMA/rxe: Remove duplicate umem assignment Shunsuke Mie
2021-08-13 11:30 ` yangx.jy
2021-08-16  1:45   ` Shunsuke Mie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).