LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: Saravana Kannan <saravanak@google.com>,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: [PATCH v1 2/2] of: property: fw_devlink: Add support for "phy-handle" property
Date: Fri, 13 Aug 2021 19:31:31 -0700 [thread overview]
Message-ID: <20210814023132.2729731-3-saravanak@google.com> (raw)
In-Reply-To: <20210814023132.2729731-1-saravanak@google.com>
Allows tracking dependencies between consumers of an Ethernet PHY and
the parent devices that own the PHY.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
Hi Andrew,
I spent a few hours looking at most/all uses of phy-handle and my
comment in the code seems valid. Can you confirm that please? Also there
are so many phy related properties that my head is spinning. Is there a
"phy" property (which is different from "phys") that treated exactly as
"phy-handle"?
-Saravana
drivers/of/property.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 931340329414..70d9843fd4bf 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1350,6 +1350,20 @@ static struct device_node *parse_interrupts(struct device_node *np,
return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.np;
}
+static struct device_node *parse_phy_handle(struct device_node *np,
+ const char *prop_name, int index)
+{
+ if (strcmp(prop_name, "phy-handle"))
+ return NULL;
+
+ /*
+ * Device tree nodes pointed to by phy-handle never have struct devices
+ * created for them even if they have a "compatible" property. So
+ * return the parent node pointer.
+ */
+ return of_get_next_parent(of_parse_phandle(np, prop_name, index));
+}
+
static const struct supplier_bindings of_supplier_bindings[] = {
{ .parse_prop = parse_clocks, },
{ .parse_prop = parse_interconnects, },
@@ -1379,6 +1393,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
{ .parse_prop = parse_resets, },
{ .parse_prop = parse_leds, },
{ .parse_prop = parse_backlight, },
+ { .parse_prop = parse_phy_handle, },
{ .parse_prop = parse_gpio_compat, },
{ .parse_prop = parse_interrupts, },
{ .parse_prop = parse_regulators, },
--
2.33.0.rc1.237.g0d66db33f3-goog
next prev parent reply other threads:[~2021-08-14 2:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 2:31 [PATCH v1 0/2] of: property: Support for few more properties Saravana Kannan
2021-08-14 2:31 ` [PATCH v1 1/2] of: property: fw_devlink: Add support for "leds" and "backlight" Saravana Kannan
2021-08-17 22:02 ` Rob Herring
2021-08-14 2:31 ` Saravana Kannan [this message]
2021-08-14 15:22 ` [PATCH v1 2/2] of: property: fw_devlink: Add support for "phy-handle" property Andrew Lunn
2021-08-16 20:43 ` Saravana Kannan
2021-08-16 21:11 ` Rob Herring
2021-08-17 18:18 ` Saravana Kannan
2021-08-16 21:15 ` Andrew Lunn
2021-08-18 2:13 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814023132.2729731-3-saravanak@google.com \
--to=saravanak@google.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH v1 2/2] of: property: fw_devlink: Add support for "phy-handle" property' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).