LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Claire Jensen <cjense@google.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@redhat.com, namhyung@kernel.org, yao.jin@linux.intel.com,
	song@kernel.org, andi@firstfloor.org, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, james.clark@arm.com,
	alexander.antonov@linux.intel.com, changbin.du@intel.com,
	liuqi115@huawei.com, irogers@google.com, eranian@google.com,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	clairej735@gmail.com
Subject: Re: [PATCH v2 1/1] perf stat: Add JSON output option.
Date: Sun, 15 Aug 2021 07:40:10 -0700	[thread overview]
Message-ID: <20210815144007.3e7cwiecbre2nt6y@two.firstfloor.org> (raw)
In-Reply-To: <20210813220754.2104922-1-cjense@google.com>

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

> CSV output example:
> 
> 1.20,msec,task-clock:u,1204272,100.00,0.697,CPUs utilized
> 0,,context-switches:u,1204272,100.00,0.000,/sec
> 0,,cpu-migrations:u,1204272,100.00,0.000,/sec
> 70,,page-faults:u,1204272,100.00,58.126,K/sec

The difficult part of such changes to perf stat is that it has
so many different output modes that all need to be tested.
Unfortunately the unit tests in perf test are not really
enough for it.

I have an older script (attached) that tests a lot of these outputs. It just
exercises them, you still need to check the output manually

Can you check that all these modes work correctly both
with and without json?

-Andi

[-- Attachment #2: STAT-REGR-TEST --]
[-- Type: text/plain, Size: 765 bytes --]

#!/bin/sh
# test perf stat output combinations with --metric-only
# output has to be manually verified

[ ! -d obj-perf ] && cd ..

set -x

PERF=${PERF:-./obj-perf/perf}

run() {
	$PERF stat -a "$@" sleep 2
}

runprog() {
	$PERF stat "$@" true
}


run
run -x, 
run --per-core
run --per-socket
run -e cycles,instructions
run -dddd

# topdown
# instructions

run -I 500
run -I 500 --per-core 
run -I 500 --per-socket 
run -I 500 -e cycles,instructions
run -I 500 -dddd

run -I 500 -x, 
run -I 500 --per-core -x, 
run -I 500 --per-socket -x, 
run -I 500 -e cycles,instructions -x, 
run -I 500 -dddd -x, 

runprog -r3
runprog -r3 -x, 
$PERF stat -r3 true
$PERF stat -r3 -x,  true

sleep 3 & 
$PERF stat --per-thread -p $! sleep 1
$PERF stat --per-thread -t $! sleep 1


  parent reply	other threads:[~2021-08-15 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 22:07 Claire Jensen
2021-08-14 13:26 ` kajoljain
2021-08-15 14:40 ` Andi Kleen [this message]
2021-08-17 17:59   ` Ian Rogers
2021-08-17 19:56     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210815144007.3e7cwiecbre2nt6y@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.antonov@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=changbin.du@intel.com \
    --cc=cjense@google.com \
    --cc=clairej735@gmail.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liuqi115@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=song@kernel.org \
    --cc=yao.jin@linux.intel.com \
    --subject='Re: [PATCH v2 1/1] perf stat: Add JSON output option.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).