LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] tracepoint: Fix the comment style
@ 2021-08-16  5:24 zhaoxiao
  2021-08-16 14:02 ` Mathieu Desnoyers
  0 siblings, 1 reply; 2+ messages in thread
From: zhaoxiao @ 2021-08-16  5:24 UTC (permalink / raw)
  To: gustavoars
  Cc: rostedt, mathieu.desnoyers, peterz, mingo, joel, linux-kernel, zhaoxiao

Fix function name in tracepoint.c kernel-doc comment
to remove a warning found by clang_w1.

kernel/tracepoint.c:589: warning: expecting prototype for register_tracepoint_notifier(). Prototype was for register_tracepoint_module_notifier() instead
kernel/tracepoint.c:613: warning: expecting prototype for unregister_tracepoint_notifier(). Prototype was for unregister_tracepoint_module_notifier() instead

Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
 kernel/tracepoint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index efd14c79fab4..64ea283f2f86 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
 static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
 
 /**
- * register_tracepoint_notifier - register tracepoint coming/going notifier
+ * register_tracepoint_module_notifier - register tracepoint coming/going notifier
  * @nb: notifier block
  *
  * Notifiers registered with this function are called on module
@@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct notifier_block *nb)
 EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
 
 /**
- * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
+ * unregister_tracepoint_module_notifier - unregister tracepoint coming/going notifier
  * @nb: notifier block
  *
  * The notifier block callback should expect a "struct tp_module" data
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] tracepoint: Fix the comment style
  2021-08-16  5:24 [PATCH] tracepoint: Fix the comment style zhaoxiao
@ 2021-08-16 14:02 ` Mathieu Desnoyers
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers @ 2021-08-16 14:02 UTC (permalink / raw)
  To: zhaoxiao, rostedt
  Cc: Gustavo A. R. Silva, Peter Zijlstra, Ingo Molnar, Joel Fernandes,
	Google, linux-kernel

----- On Aug 16, 2021, at 1:24 AM, zhaoxiao zhaoxiao@uniontech.com wrote:

> Fix function name in tracepoint.c kernel-doc comment
> to remove a warning found by clang_w1.
> 
> kernel/tracepoint.c:589: warning: expecting prototype for
> register_tracepoint_notifier(). Prototype was for
> register_tracepoint_module_notifier() instead
> kernel/tracepoint.c:613: warning: expecting prototype for
> unregister_tracepoint_notifier(). Prototype was for
> unregister_tracepoint_module_notifier() instead

Thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

> 
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> kernel/tracepoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> index efd14c79fab4..64ea283f2f86 100644
> --- a/kernel/tracepoint.c
> +++ b/kernel/tracepoint.c
> @@ -577,7 +577,7 @@ bool trace_module_has_bad_taint(struct module *mod)
> static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
> 
> /**
> - * register_tracepoint_notifier - register tracepoint coming/going notifier
> + * register_tracepoint_module_notifier - register tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * Notifiers registered with this function are called on module
> @@ -603,7 +603,7 @@ int register_tracepoint_module_notifier(struct
> notifier_block *nb)
> EXPORT_SYMBOL_GPL(register_tracepoint_module_notifier);
> 
> /**
> - * unregister_tracepoint_notifier - unregister tracepoint coming/going notifier
> + * unregister_tracepoint_module_notifier - unregister tracepoint coming/going
> notifier
>  * @nb: notifier block
>  *
>  * The notifier block callback should expect a "struct tp_module" data
> --
> 2.20.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-16 14:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16  5:24 [PATCH] tracepoint: Fix the comment style zhaoxiao
2021-08-16 14:02 ` Mathieu Desnoyers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).