Re: Patch formatting - Re:

[Willy Tarreau <w@1wt.eu>]

On Mon, Aug 16, 2021 at 09:04:57AM +0200, John Paul Adrian Glaubitz wrote:
> Hi Zhao!
> 
> Thanks for your patch!
> 
> However, the patch has not been properly formatted and needs to be resend.
> 
> Could you follow this guide [1] and send your patch again in the correct
> format?

Adrian, it would be nice to give some hints about what has to be fixed,
because it's not necessarily easy to be able to figure this by comparing
one's patch to an example in a blog article.

Zhao, some hints:
  - the subject line doesn't make it obvious what subsystem is being touched.
    Often running "git log" on the file(s) you change can help you figure what
    others commonly use ;

  - the commit message is empty, it should carry a description of what you
    are trying to improve or fix, and when relevant, some indications about
    how you decided to address that. A good hint is to think that you're
    trying to "sell" your patch to someone else who will become responsible
    for maintaining it, thus put all the selling arguments there :-)

  - often a Cc list is desired if it touches areas that may impact others,
    as well as their maintainers ;

  - using git-send-email like in the article is generally preferred as it
    makes the process smoother on the receiver's end. It can look scary
    at first, making you fear to accidentally send poorly formatted
    e-mails, but in practice it's rare, and recipients are used to seeing
    this and are very tolerant to this :-)

And yes, reading Nick's article is definitely a good idea!

> Thanks,
> Adrian

Regards,
Willy