LKML Archive on
help / color / mirror / Atom feed
From: Willy Tarreau <>
To: John Paul Adrian Glaubitz <>
Cc: zhao xc <>,,,,
Subject: Re: Patch formatting - Re:
Date: Mon, 16 Aug 2021 09:22:13 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Aug 16, 2021 at 09:04:57AM +0200, John Paul Adrian Glaubitz wrote:
> Hi Zhao!
> Thanks for your patch!
> However, the patch has not been properly formatted and needs to be resend.
> Could you follow this guide [1] and send your patch again in the correct
> format?

Adrian, it would be nice to give some hints about what has to be fixed,
because it's not necessarily easy to be able to figure this by comparing
one's patch to an example in a blog article.

Zhao, some hints:
  - the subject line doesn't make it obvious what subsystem is being touched.
    Often running "git log" on the file(s) you change can help you figure what
    others commonly use ;

  - the commit message is empty, it should carry a description of what you
    are trying to improve or fix, and when relevant, some indications about
    how you decided to address that. A good hint is to think that you're
    trying to "sell" your patch to someone else who will become responsible
    for maintaining it, thus put all the selling arguments there :-)

  - often a Cc list is desired if it touches areas that may impact others,
    as well as their maintainers ;

  - using git-send-email like in the article is generally preferred as it
    makes the process smoother on the receiver's end. It can look scary
    at first, making you fear to accidentally send poorly formatted
    e-mails, but in practice it's rare, and recipients are used to seeing
    this and are very tolerant to this :-)

And yes, reading Nick's article is definitely a good idea!

> Thanks,
> Adrian


      reply	other threads:[~2021-08-16  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  5:59 zhao xc
2021-08-16  7:04 ` Patch formatting - John Paul Adrian Glaubitz
2021-08-16  7:22   ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: Patch formatting - Re:' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).