LKML Archive on
help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Nathan Chancellor <>
Cc: Greg Kroah-Hartman <>,
	Phillip Potter <>,
	Larry Finger <>,,,
	"Fabio M . De Francesco" <>
Subject: Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()
Date: Mon, 16 Aug 2021 12:05:00 +0300	[thread overview]
Message-ID: <20210816090500.GG1931@kadam> (raw)
In-Reply-To: <>

To be honest, I prefered the original.

	foo = alloc();
	if (!foo) {
		ret = -EWHATEVER;
		goto free_last_thing;

I like this style of error handling because all the information is
there.  You don't need to scroll down.

I don't really care about this specific patch at all.  It's a small
thing.  But we had someone come through who was sort of obsessed with
removing these sorts of variables.  Just because you can remove a
variable doesn't necessarily make the code more readable.

If you're doing the work and maintaining the driver you get to choose
your own style to some extent.  But I don't want to encourage people to
start sending these sort of patches more generally.

dan carpenter

  parent reply	other threads:[~2021-08-16  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 20:14 Nathan Chancellor
2021-08-13 21:55 ` Fabio M. De Francesco
2021-08-14 17:16 ` Phillip Potter
2021-08-16  9:05 ` Dan Carpenter [this message]
2021-08-16 10:15   ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816090500.GG1931@kadam \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] staging: r8188eu: Remove unnecessary ret variable in rtw_drv_init()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).