LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com> To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube <straube.linux@gmail.com> Subject: [PATCH 3/4] staging: r8188eu: refactor rtw_is_cckratesonly_included() Date: Mon, 16 Aug 2021 11:58:39 +0200 [thread overview] Message-ID: <20210816095840.24259-3-straube.linux@gmail.com> (raw) In-Reply-To: <20210816095840.24259-1-straube.linux@gmail.com> Refactor function rtw_is_cckratesonly_included(). Improves readability and slightly reduces object file size. Signed-off-by: Michael Straube <straube.linux@gmail.com> --- drivers/staging/r8188eu/core/rtw_ieee80211.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_ieee80211.c b/drivers/staging/r8188eu/core/rtw_ieee80211.c index c8627ad83006..200c90b8ea51 100644 --- a/drivers/staging/r8188eu/core/rtw_ieee80211.c +++ b/drivers/staging/r8188eu/core/rtw_ieee80211.c @@ -82,15 +82,13 @@ bool rtw_is_cckrates_included(u8 *rate) uint rtw_is_cckratesonly_included(u8 *rate) { - u32 i = 0; + while (*rate) { + u8 r = *rate & 0x7f; - while (rate[i] != 0) { - if ((((rate[i]) & 0x7f) != 2) && (((rate[i]) & 0x7f) != 4) && - (((rate[i]) & 0x7f) != 11) && (((rate[i]) & 0x7f) != 22)) + if (r != 2 && r != 4 && r != 11 && r != 22) return false; - i++; + rate++; } - return true; } -- 2.32.0
next prev parent reply other threads:[~2021-08-16 9:59 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-16 9:58 [PATCH 1/4] staging: r8188eu: refactor rtw_is_cckrates_included() Michael Straube 2021-08-16 9:58 ` [PATCH 2/4] staging: r8188eu: convert rtw_is_cckrates_included() to bool Michael Straube 2021-08-16 9:58 ` Michael Straube [this message] 2021-08-16 9:58 ` [PATCH 4/4] staging: r8188eu: convert rtw_is_cckratesonly_included() " Michael Straube 2021-08-16 11:14 ` [PATCH 1/4] staging: r8188eu: refactor rtw_is_cckrates_included() Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210816095840.24259-3-straube.linux@gmail.com \ --to=straube.linux@gmail.com \ --cc=Larry.Finger@lwfinger.net \ --cc=fmdefrancesco@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=martin@kaiser.cx \ --cc=phil@philpotter.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).