From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CF6C4338F for ; Mon, 16 Aug 2021 09:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65A3D61B80 for ; Mon, 16 Aug 2021 09:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235518AbhHPJzM (ORCPT ); Mon, 16 Aug 2021 05:55:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbhHPJzL (ORCPT ); Mon, 16 Aug 2021 05:55:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5935461B72; Mon, 16 Aug 2021 09:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629107679; bh=rPHYIXTB11jTLUaw8xSCpjfzdCFfMm8VFV2GzvAfkb4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VRO2j5/pJm8WYPaiWFwt+7bLKrzguPBjC5t2HwDyEw/hO9mS9lnlYzT30/siBqKmo fihZOGhDsy5WPhwnCQb4NXdCmrYAmtUagg709AtqRy2ihFBZQGgsffrxZlUj8NLx/a kXEgVTEmul7EsrDKemw5iroi+8ats8kZgUx994kjA2aG13639FbgtrlStAyR8VAx2h iTWDF6Qrvj5lmxHw9qxl9y4PabIWaicc+p+vRnb7gl/EZE0uJsAiR61kDQN/NWnNrL yrlb3m1Puph3mSkyWDHLEOgCs21qyJBlOa+lGV818PHpLDgcsLkJ9oXz+g6StasqSc AQFxuyWZkbalg== Date: Mon, 16 Aug 2021 11:54:35 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Song, Yoong Siang" Cc: Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Message-ID: <20210816115435.664d921b@dellmb> In-Reply-To: References: <20210813084536.182381-1-yoong.siang.song@intel.com> <20210814172656.GA22278@shell.armlinux.org.uk> <20210814194916.GB22278@shell.armlinux.org.uk> <20210816071419.GF22278@shell.armlinux.org.uk> <20210816081812.GH22278@shell.armlinux.org.uk> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Aug 2021 08:56:36 +0000 "Song, Yoong Siang" wrote: > Yes, you are right. I missed the effect of get_wol. > Is it needed in future to implement link change interrupt in phy > driver? Cause I dint see much phy driver implement link change > interrupt. If there is a board that has interrupt pin wired correctly from the PHY and the interrupt controller is safe to use (i.e. it is not a PCA953x which cannot handle interrupt storms correctly), then I think the PHY driver should use the interrupt, instead of polling. Marek