LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [REGRESSION][BISECTED] flood of "hid-generic ... control queue full" since v5.14-rc1
Date: Mon, 16 Aug 2021 10:38:56 -0400	[thread overview]
Message-ID: <20210816143856.GA121345@rowland.harvard.edu> (raw)
In-Reply-To: <20210816141347.zougsudwe5tqgkpt@lion.mk-sys.cz>

On Mon, Aug 16, 2021 at 04:13:47PM +0200, Michal Kubecek wrote:
> On Mon, Aug 16, 2021 at 03:26:20PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 16, 2021 at 03:00:59PM +0200, Michal Kubecek wrote:
> > > Hello,
> > > 
> > > starting with v5.14-rc1, my kernel log gets flooded with messages
> > > 
> > >   hid-generic 0003:051D:0002.0002: control queue full
> > > 
> > > at rate of ~33 per second. Device 051d:0002 is an APC UPS (BR-650 VA).
> > > I bisected the issue to commit
> > > 
> > >   7652dd2c5cb7 ("USB: core: Check buffer length matches wLength for control transfers")
> > > 
> > > Reverting this commit on top of v5.14-rc6 resolves the issue. I suspect
> > > the problem is some missing cleanup when usb_submit_urb() bails out on
> > > the newly added check but I'm not familiar enough with the code to see
> > > what is missing or if the problem is on USB or HID side.

...

> Looking at the code, the primary problem seems to be that the "else"
> branch in hid_submit_ctrl() recalculates transfer_buffer_length to
> a rounded up value but assigns the original length to wLength.

Looks like you found the bug.  Fixing it might be as simple as setting 
len = padlen in that "else" branch.  You could then combine the 
transfer_buffer_length assignment with the one in the "if" branch and 
hoist them out after the entire "if" statement.

Alan Stern

  reply	other threads:[~2021-08-16 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 13:00 Michal Kubecek
2021-08-16 13:26 ` Greg Kroah-Hartman
2021-08-16 14:13   ` Michal Kubecek
2021-08-16 14:38     ` Alan Stern [this message]
2021-08-16 19:12       ` Michal Kubecek
2021-08-30 15:48         ` Oleksandr Natalenko
2021-08-30 16:07           ` Alan Stern
2021-08-30 16:31             ` Benjamin Tissoires
2021-08-30 19:23         ` Holger Hoffstätte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816143856.GA121345@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=benjamin.tissoires@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --subject='Re: [REGRESSION][BISECTED] flood of "hid-generic ... control queue full" since v5.14-rc1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).