LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Daniel Bristot de Oliveira <bristot@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] Makefile: use -Wno-main in the full kernel tree
Date: Mon, 16 Aug 2021 22:05:57 -0400	[thread overview]
Message-ID: <20210816220557.2253bc10@oasis.local.home> (raw)
In-Reply-To: <CAHk-=wiA2wnA-3_iVjN9kUf-Gve2jD8UzDkvhDGLg=R=O1vN9g@mail.gmail.com>

On Mon, 16 Aug 2021 15:31:33 -1000
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Mon, Aug 16, 2021 at 3:01 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > That sounds likely. We can just ignore this if you had rather go that way.  
> 
> I'm happy doing it, I don't think the Wmain warnings buy anything for
> the kernel. My main worry is just that some compiler version might not
> support it at all or similar, and it would cause problems that way.
> 
> Which is really the only reason why I'd like to narrow it down as much
> as (trivially) possible.
> 
> It doesn't sound worth trying to pinpoint exact gcc version, but
> making it gcc-only would at least narrow it down a _bit_.

Looks to me that -Wmain and -Wno-main have been in gcc for a long time.
If we limit it to just gcc, I believe it will not be an issue for any
compiler version the kernel supports.

  https://gcc.gnu.org/onlinedocs/gcc/Option-Index.html

And perhaps you are correct, as this is not a new option (it's in all
the gcc versions I have (tested back to 4.2.4)), and it didn't trigger
for me, I too believe this was a bug in a particular version that Randy
used.

-- Steve

  reply	other threads:[~2021-08-17  2:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 22:41 Randy Dunlap
2021-08-14  0:01 ` Linus Torvalds
2021-08-14  0:29   ` Randy Dunlap
2021-08-17  0:33   ` Linus Torvalds
2021-08-17  0:38     ` Linus Torvalds
2021-08-17  1:01       ` Randy Dunlap
2021-08-17  1:31         ` Linus Torvalds
2021-08-17  2:05           ` Steven Rostedt [this message]
2021-08-21 23:26     ` Randy Dunlap
2021-09-07 22:42     ` Randy Dunlap
2021-08-16 15:08 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816220557.2253bc10@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=bristot@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=rdunlap@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] Makefile: use -Wno-main in the full kernel tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).