LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
Matt Corallo <oc2udbzfd@mattcorallo.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Emiliano Ingrassia <ingrassia@epigenesys.com>,
Brian Kim <brian.kim@hardkernel.com>
Subject: [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER
Date: Tue, 17 Aug 2021 09:45:40 +0530 [thread overview]
Message-ID: <20210817041548.1276-7-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210817041548.1276-1-linux.amoon@gmail.com>
devm_phy_create can return -EPROBE_DEFER if the vbus-supply is not ready
yet. Silence this warning as the driver framework will re-attempt
registering the PHY. Use dev_err_probe() for phy resources to indicate
the deferral reason when waiting for the resource to come up.
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
None.
---
drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c
index 2aad45c55494..cf10bed40528 100644
--- a/drivers/phy/amlogic/phy-meson8b-usb2.c
+++ b/drivers/phy/amlogic/phy-meson8b-usb2.c
@@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops);
if (IS_ERR(phy)) {
- dev_err(&pdev->dev, "failed to create PHY\n");
- return PTR_ERR(phy);
+ return dev_err_probe(&pdev->dev, PTR_ERR(phy),
+ "failed to create PHY\n");
}
phy_set_drvdata(phy, priv);
--
2.32.0
next prev parent reply other threads:[~2021-08-17 4:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 4:15 [PATCHv3 0/6] Meson-8b and Meson-gxbb Fix some missing code Anand Moon
2021-08-17 4:15 ` [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node Anand Moon
2021-08-28 15:53 ` Martin Blumenstingl
2021-08-30 7:45 ` Neil Armstrong
2021-08-30 19:37 ` Martin Blumenstingl
2021-08-31 14:50 ` Neil Armstrong
2021-08-31 20:47 ` Anand Moon
2021-09-20 19:26 ` Martin Blumenstingl
2021-09-25 17:41 ` Anand Moon
2021-08-17 4:15 ` [PATCHv3 2/6] ARM: dts: meson8b: odroidc1: Set usb power source to always on Anand Moon
2021-08-28 15:56 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Anand Moon
2021-08-28 16:00 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 4/6] arm64: dts: amlogic: odroidc2: use vbus-supply for power source for usb nodes Anand Moon
2021-08-28 16:06 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 5/6] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-08-17 10:30 ` Vinod Koul
2021-08-17 4:15 ` Anand Moon [this message]
2021-08-17 10:31 ` [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817041548.1276-7-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=brian.kim@hardkernel.com \
--cc=devicetree@vger.kernel.org \
--cc=ingrassia@epigenesys.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=oc2udbzfd@mattcorallo.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--subject='Re: [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don'\''t log an error on -EPROBE_DEFER' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).