LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pip Cet <pipcet@gmail.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [asahilinux:pr/8 15/16] drivers/irqchip/irq-apple-fiq.c:537:40: error: 'FIQ_OTHER' undeclared
Date: Tue, 17 Aug 2021 06:42:05 +0800	[thread overview]
Message-ID: <202108170658.4ufepW1u-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4380 bytes --]

tree:   https://github.com/AsahiLinux/linux pr/8
head:   d87a0dc99e28480d67b993f52d066bd2bf58207c
commit: 44401c9ad669cb9e5443a73a7b504d253dec0a8c [15/16] irq-apple-fiq: FIQ code adjustments
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/AsahiLinux/linux/commit/44401c9ad669cb9e5443a73a7b504d253dec0a8c
        git remote add asahilinux https://github.com/AsahiLinux/linux
        git fetch --no-tags asahilinux pr/8
        git checkout 44401c9ad669cb9e5443a73a7b504d253dec0a8c
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-apple-fiq.c: In function 'ipi_domain_alloc':
   drivers/irqchip/irq-apple-fiq.c:390:9: warning: unused variable 'ret' [-Wunused-variable]
     390 |  int i, ret;
         |         ^~~
   drivers/irqchip/irq-apple-fiq.c:389:18: warning: unused variable 'hwirq' [-Wunused-variable]
     389 |  irq_hw_number_t hwirq;
         |                  ^~~~~
   drivers/irqchip/irq-apple-fiq.c:388:15: warning: unused variable 'type' [-Wunused-variable]
     388 |  unsigned int type = IRQ_TYPE_NONE;
         |               ^~~~
   drivers/irqchip/irq-apple-fiq.c: In function 'fiq_of_ic_init':
>> drivers/irqchip/irq-apple-fiq.c:537:40: error: 'FIQ_OTHER' undeclared (first use in this function)
     537 |  if (__irq_resolve_mapping(ic->domain, FIQ_OTHER, &fiq_other))
         |                                        ^~~~~~~~~
   drivers/irqchip/irq-apple-fiq.c:537:40: note: each undeclared identifier is reported only once for each function it appears in
   At top level:
   drivers/irqchip/irq-apple-fiq.c:194:13: warning: 'fiq_ipi_eoi' defined but not used [-Wunused-function]
     194 | static void fiq_ipi_eoi(struct irq_data *d)
         |             ^~~~~~~~~~~


vim +/FIQ_OTHER +537 drivers/irqchip/irq-apple-fiq.c

   488	
   489	static int __init fiq_of_ic_init(struct device_node *node, struct device_node *parent)
   490	{
   491		struct fiq_irq_chip *ic;
   492		unsigned int fiq_other;
   493		int base_ipi = 0;
   494		bool use_for_ipi = of_property_read_bool(node, "use-for-ipi");
   495	
   496		ic = kzalloc(sizeof(*ic), GFP_KERNEL);
   497		if (!ic)
   498			return -ENOMEM;
   499	
   500		fiq_irqc = ic;
   501	
   502		ic->domain = irq_domain_create_linear(of_node_to_fwnode(node),
   503						      NR_FIQ, &irq_domain_ops, ic);
   504		if (WARN_ON(!ic->domain)) {
   505			kfree(ic);
   506			return -ENODEV;
   507		}
   508	
   509		ic->ipi_domain =
   510			irq_domain_create_hierarchy(NULL,
   511						    IRQ_DOMAIN_FLAG_IPI_SINGLE,
   512						    FIQ_NR_IPI,
   513						    __irq_domain_alloc_fwnode(IRQCHIP_FWNODE_NAMED, 0, "fiq-ipi", NULL),
   514						    &ipi_domain_ops, ic);
   515		if (ic->ipi_domain) {
   516			if (use_for_ipi) {
   517				irq_domain_update_bus_token(ic->ipi_domain, DOMAIN_BUS_IPI);
   518	
   519				base_ipi =__irq_domain_alloc_irqs(ic->ipi_domain, -1, FIQ_NR_IPI,
   520								  NUMA_NO_NODE, NULL, false, NULL);
   521	
   522				printk("base IPI %d\n", base_ipi);
   523				if (base_ipi >= 0)
   524					set_smp_ipi_range(base_ipi, FIQ_NR_IPI);
   525			}
   526		}
   527	
   528		set_handle_fiq(handle_fiq);
   529	
   530		if (!is_kernel_in_hyp_mode())
   531			pr_info("Kernel running in EL1, mapping interrupts");
   532	
   533		cpuhp_setup_state(CPUHP_AP_IRQ_APPLE_FIQ_STARTING,
   534				  "irqchip/apple-fiq/fiq:starting",
   535				  fiq_init_cpu, NULL);
   536	
 > 537		if (__irq_resolve_mapping(ic->domain, FIQ_OTHER, &fiq_other))
   538			WARN_ON(request_irq(fiq_other, fiq_handler, IRQF_SHARED,
   539					    "PMC FIQ handler", ic) < 0);
   540	
   541		pr_info("Initialized with %d FIQs, %sused for IPI\n", NR_FIQ,
   542			use_for_ipi ? "" : "not ");;
   543	
   544		return 0;
   545	}
   546	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77912 bytes --]

                 reply	other threads:[~2021-08-16 22:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108170658.4ufepW1u-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pipcet@gmail.com \
    --subject='Re: [asahilinux:pr/8 15/16] drivers/irqchip/irq-apple-fiq.c:537:40: error: '\''FIQ_OTHER'\'' undeclared' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).