LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the mtd tree
@ 2021-08-16 22:06 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2021-08-16 22:06 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: Zhihao Cheng, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  e128bf2f39da ("mtd: mtdconcat: Remove concat_{read|write}_oob")

Fixes tag

  Fixes: 2431c4f5b46c3("mtd: Implement mtd_{read,write}() around ...")

has these problem(s):

  - missing space between the SHA1 and the subject
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* linux-next: Fixes tag needs some work in the mtd tree
@ 2021-08-17 21:58 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2021-08-17 21:58 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: Zhihao Cheng, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

In commit

  a89d69a44e28 ("mtd: mtdconcat: Check _read, _write callbacks existence before assignment")

Fixes tag

  Fixes: 2431c4f5b46c3 ("mtd: Implement mtd_{read,write}() around ...")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 2431c4f5b46c ("mtd: Implement mtd_{read,write}() as wrappers around mtd_{read,write}_oob()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-17 21:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 22:06 linux-next: Fixes tag needs some work in the mtd tree Stephen Rothwell
2021-08-17 21:58 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).