LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clk: staging: correct reference to config IOMEM to config HAS_IOMEM
@ 2021-08-17 10:54 Lukas Bulwahn
  2021-08-19 17:57 ` David Gow
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-08-17 10:54 UTC (permalink / raw)
  To: Greg Kroah-Hartman, David Gow, linux-staging
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx
Clocking Wizard driver") introduces a dependency on the non-existing config
IOMEM, which basically makes it impossible to include this driver into any
build. Fortunately, ./scripts/checkkconfigsymbols.py warns:

IOMEM
Referencing files: drivers/staging/clocking-wizard/Kconfig

The config for IOMEM support is called HAS_IOMEM. Correct this reference to
the intended config.

Fixes: 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/staging/clocking-wizard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/clocking-wizard/Kconfig b/drivers/staging/clocking-wizard/Kconfig
index 69cf51445f08..2324b5d73788 100644
--- a/drivers/staging/clocking-wizard/Kconfig
+++ b/drivers/staging/clocking-wizard/Kconfig
@@ -5,6 +5,6 @@
 
 config COMMON_CLK_XLNX_CLKWZRD
 	tristate "Xilinx Clocking Wizard"
-	depends on COMMON_CLK && OF && IOMEM
+	depends on COMMON_CLK && OF && HAS_IOMEM
 	help
 	  Support for the Xilinx Clocking Wizard IP core clock generator.
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: staging: correct reference to config IOMEM to config HAS_IOMEM
  2021-08-17 10:54 [PATCH] clk: staging: correct reference to config IOMEM to config HAS_IOMEM Lukas Bulwahn
@ 2021-08-19 17:57 ` David Gow
  0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2021-08-19 17:57 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Greg Kroah-Hartman, linux-staging, kernel-janitors,
	Linux Kernel Mailing List

On Tue, Aug 17, 2021 at 6:54 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx
> Clocking Wizard driver") introduces a dependency on the non-existing config
> IOMEM, which basically makes it impossible to include this driver into any
> build. Fortunately, ./scripts/checkkconfigsymbols.py warns:
>
> IOMEM
> Referencing files: drivers/staging/clocking-wizard/Kconfig
>
> The config for IOMEM support is called HAS_IOMEM. Correct this reference to
> the intended config.
>
> Fixes: 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Whoops! Thanks for picking up on this: I thought I'd fixed it, but it
was actually for another driver.

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-19 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 10:54 [PATCH] clk: staging: correct reference to config IOMEM to config HAS_IOMEM Lukas Bulwahn
2021-08-19 17:57 ` David Gow

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).