LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ronak Jain <ronak.jain@xilinx.com>
To: <michal.simek@xilinx.com>, <linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <rajan.vaja@xilinx.com>,
	<corbet@lwn.net>, <linux-arm-kernel@lists.infradead.org>,
	<arnd@arndb.de>, <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Ronak Jain <ronak.jain@xilinx.com>
Subject: [PATCH 2/3] firmware: zynqmp: Add sysfs entry for runtime features
Date: Tue, 17 Aug 2021 06:05:52 -0700	[thread overview]
Message-ID: <20210817130553.20219-3-ronak.jain@xilinx.com> (raw)
In-Reply-To: <20210817130553.20219-1-ronak.jain@xilinx.com>

Create sysfs entry for runtime feature configuration. Here the support
 is added for an over temperature and external watchdog feature.

The below listed path is used for runtime features configuration:
/sys/devices/platform/firmware\:zynqmp-firmware/*

Here there are two files to configure features at runtime.
1. feature_config_id
2. feature_config_value

In order to configure an over temperature or external watchdog
 features, first the user need to select the valid config id and then
 the user can configure the value for selected feature config id.

Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
---
 .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
index f5724bb5b462..2fde354715a5 100644
--- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
+++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
@@ -113,3 +113,87 @@ Description:
                    # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/health_status

 Users:         Xilinx
+
+What:          /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_*
+Date:          Aug 2021
+KernelVersion: 5.14
+Contact:       "Ronak Jain" <ronak.jain@xilinx.com>
+Description:
+               This sysfs interface allows to configure features at runtime.
+               The user can enable or disable features running at firmware.
+               Also, the user can configure the parameters of the features
+               at runtime. The supported features are over temperature and
+               external watchdog. Here, the external watchdog is completely
+               different than the /dev/watchdog as the external watchdog is
+               running on the firmware and it is used to monitor the health
+               of firmware not APU(Linux). Also, the external watchdog is
+               interfaced outside of the zynqmp soc.
+
+               By default the features are disabled in the firmware. The user
+               can enable features by querying appropriate config id of the
+               features.
+
+               The default limit for the over temperature is 90 Degree Celsius.
+               The default timer interval for the external watchdog is 570ms.
+
+               The supported config ids are for the feature configuration is,
+               1. PM_FEATURE_OVERTEMP_STATUS = 1, the user can enable or
+               disable the over temperature feature.
+               2. PM_FEATURE_OVERTEMP_VALUE = 2, the user can configure the
+               over temperature limit in Degree Celsius.
+               3. PM_FEATURE_EXTWDT_STATUS = 3, the user can enable or disable
+               the external watchdog feature.
+               4. PM_FEATURE_EXTWDT_VALUE = 4, the user can configure the
+               external watchdog feature.
+
+               Usage:
+
+               Enable over temperature feature
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature feature is enabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 1.
+
+               Disable over temperature feature
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature feature is disabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 0.
+
+               Configure over temperature limit to 50 Degree Celsius
+               # echo 2 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 50 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the over temperature limit is configured or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 50.
+
+               Enable external watchdog feature
+               # echo 3 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog feature is enabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 1.
+
+               Disable external watchdog feature
+               # echo 3 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 0 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog feature is disabled or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 0.
+
+               Configure external watchdog timer interval to 500ms
+               # echo 4 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
+               # echo 500 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+
+               Check whether the external watchdog timer interval is configured or not
+               # cat /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
+               The expected result is 500.
+
+Users:         Xilinx
--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

  parent reply	other threads:[~2021-08-17 13:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 13:05 [PATCH 0/3] Add support " Ronak Jain
2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
2021-08-17 13:05 ` Ronak Jain [this message]
2021-08-17 13:05 ` [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config Ronak Jain
2021-08-18  6:43 ` [PATCH 0/3] Add support for runtime features Michael Tretter
2021-08-18  8:08 ` Greg KH
2021-08-19  3:57   ` Ronak Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817130553.20219-3-ronak.jain@xilinx.com \
    --to=ronak.jain@xilinx.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --subject='Re: [PATCH 2/3] firmware: zynqmp: Add sysfs entry for runtime features' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).