LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ronak Jain <ronak.jain@xilinx.com>
To: <michal.simek@xilinx.com>, <linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <rajan.vaja@xilinx.com>,
	<corbet@lwn.net>, <linux-arm-kernel@lists.infradead.org>,
	<arnd@arndb.de>, <lakshmi.sai.krishna.potthuri@xilinx.com>,
	Ronak Jain <ronak.jain@xilinx.com>
Subject: [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config
Date: Tue, 17 Aug 2021 06:05:53 -0700	[thread overview]
Message-ID: <20210817130553.20219-4-ronak.jain@xilinx.com> (raw)
In-Reply-To: <20210817130553.20219-1-ronak.jain@xilinx.com>

This patch adds support for sysfs interface for runtime features
 configuration. The user can configure the features at runtime. First
 the user need to select the config id of the supported features and
 then the user can configure the parameters of the feature based on
 the config id. So far the support is added for the over temperature
 and external watchdog features.

Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
---
 drivers/firmware/xilinx/zynqmp.c | 71 ++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index e2b0a8fb6f44..4c5010899837 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -1344,6 +1344,75 @@ static DEVICE_ATTR_RW(pggs1);
 static DEVICE_ATTR_RW(pggs2);
 static DEVICE_ATTR_RW(pggs3);

+static atomic_t feature_conf_id;
+
+static ssize_t feature_config_id_show(struct device *device,
+                                     struct device_attribute *attr,
+                                     char *buf)
+{
+       return sysfs_emit(buf, "%d\n", atomic_read(&feature_conf_id));
+}
+
+static ssize_t feature_config_id_store(struct device *device,
+                                      struct device_attribute *attr,
+                                      const char *buf, size_t count)
+{
+       u32 config_id;
+       int ret;
+
+       if (!buf)
+               return -EINVAL;
+
+       ret = kstrtou32(buf, 10, &config_id);
+       if (ret)
+               return ret;
+
+       atomic_set(&feature_conf_id, config_id);
+
+       return count;
+}
+
+static DEVICE_ATTR_RW(feature_config_id);
+
+static ssize_t feature_config_value_show(struct device *device,
+                                        struct device_attribute *attr,
+                                        char *buf)
+{
+       int ret;
+       u32 ret_payload[PAYLOAD_ARG_CNT];
+
+       ret = zynqmp_pm_get_feature_config(atomic_read(&feature_conf_id),
+                                          ret_payload);
+       if (ret)
+               return ret;
+
+       return sysfs_emit(buf, "%d\n", ret_payload[1]);
+}
+
+static ssize_t feature_config_value_store(struct device *device,
+                                         struct device_attribute *attr,
+                                         const char *buf, size_t count)
+{
+       u32 value;
+       int ret;
+
+       if (!buf)
+               return -EINVAL;
+
+       ret = kstrtou32(buf, 10, &value);
+       if (ret)
+               return ret;
+
+       ret = zynqmp_pm_set_feature_config(atomic_read(&feature_conf_id),
+                                          value);
+       if (ret)
+               return ret;
+
+       return count;
+}
+
+static DEVICE_ATTR_RW(feature_config_value);
+
 static struct attribute *zynqmp_firmware_attrs[] = {
        &dev_attr_ggs0.attr,
        &dev_attr_ggs1.attr,
@@ -1355,6 +1424,8 @@ static struct attribute *zynqmp_firmware_attrs[] = {
        &dev_attr_pggs3.attr,
        &dev_attr_shutdown_scope.attr,
        &dev_attr_health_status.attr,
+       &dev_attr_feature_config_id.attr,
+       &dev_attr_feature_config_value.attr,
        NULL,
 };

--
2.32.0.93.g670b81a

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

  parent reply	other threads:[~2021-08-17 13:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 13:05 [PATCH 0/3] Add support for runtime features Ronak Jain
2021-08-17 13:05 ` [PATCH 1/3] firmware: xilinx: " Ronak Jain
2021-08-17 13:05 ` [PATCH 2/3] firmware: zynqmp: Add sysfs entry " Ronak Jain
2021-08-17 13:05 ` Ronak Jain [this message]
2021-08-18  6:43 ` [PATCH 0/3] Add support " Michael Tretter
2021-08-18  8:08 ` Greg KH
2021-08-19  3:57   ` Ronak Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817130553.20219-4-ronak.jain@xilinx.com \
    --to=ronak.jain@xilinx.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --subject='Re: [PATCH 3/3] firmware: xilinx: Add sysfs support for feature config' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).