LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: lgirdwood@gmail.com, ulf.hansson@linaro.org,
	lee.jones@linaro.org, zhangchangzhong@huawei.com,
	heiko@sntech.de, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify
Date: Tue, 17 Aug 2021 15:36:12 +0100	[thread overview]
Message-ID: <20210817143612.GB4290@sirena.org.uk> (raw)
In-Reply-To: <20210817033848.1396749-4-jay.xu@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Tue, Aug 17, 2021 at 11:38:48AM +0800, Jianqun Xu wrote:

> +	} else if (event & REGULATOR_EVENT_ENABLE) {
> +		uV = regulator_get_voltage(supply->reg);
>  	} else {

I am very surprised this doesn't cause locking issues given that we
might call notifiers with the regulator API's locks held.  Have you
tested this with lockdep on?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2021-08-17 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  3:38 [PATCH v2 0/3] regulator pre-enable Jianqun Xu
2021-08-17  3:38 ` [PATCH v2 1/3] regulator: add PRE_ENABLE event define Jianqun Xu
2021-08-18 12:56   ` Mark Brown
2021-08-17  3:38 ` [PATCH v2 2/3] regulator: core: add pre-enable event notify to regulator Jianqun Xu
2021-08-17  3:38 ` [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify Jianqun Xu
2021-08-17 14:36   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817143612.GB4290@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangchangzhong@huawei.com \
    --subject='Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).