LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] x86: intel_epb: Mention firmware in ENERGY_PERF_BIAS warning
Date: Tue, 17 Aug 2021 16:38:29 +0200 [thread overview]
Message-ID: <20210817143830.34552-1-pmenzel@molgen.mpg.de> (raw)
The warning
ENERGY_PERF_BIAS: Set to 'normal', was 'performance'
is shown on all my Intel systems, and for a normal user it’s unclear
what to do about it. Change it to
ENERGY_PERF_BIAS: Set to 'normal', was 'performance' (unchanged by firmware)
so it’s clear, that it might be possible to change the setting in the
system firmware.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
arch/x86/kernel/cpu/intel_epb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/intel_epb.c b/arch/x86/kernel/cpu/intel_epb.c
index f4dd73396f28..3f8c0b59d08a 100644
--- a/arch/x86/kernel/cpu/intel_epb.c
+++ b/arch/x86/kernel/cpu/intel_epb.c
@@ -91,7 +91,7 @@ static void intel_epb_restore(void)
val = epb & EPB_MASK;
if (val == ENERGY_PERF_BIAS_PERFORMANCE) {
val = ENERGY_PERF_BIAS_NORMAL;
- pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
+ pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance' (unchanged by firmware)\n");
}
}
wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, (epb & ~EPB_MASK) | val);
--
2.33.0
next reply other threads:[~2021-08-17 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 14:38 Paul Menzel [this message]
2021-08-17 14:38 ` [PATCH 2/2] x86: intel_epb: Decrease ENERGY_PERF_BIAS warning to info log message Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817143830.34552-1-pmenzel@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--subject='Re: [PATCH 1/2] x86: intel_epb: Mention firmware in ENERGY_PERF_BIAS warning' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).