LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][next] iio: adc: Fix -EBUSY timeout error return
@ 2021-08-17 17:21 Colin King
  2021-08-18 15:50 ` Prabhakar Mahadev Lad
  0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2021-08-17 17:21 UTC (permalink / raw)
  To: Lad Prabhakar, Jonathan Cameron, Lars-Peter Clausen, Biju Das,
	linux-iio, linux-renesas-soc
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Currently when a timeout occurs in rzg2l_adc_hw_init the error -EBUSY is
assigned to ret but the error code is used as the function is hard-coded
to return 0.  The variable ret is 0 before entering the while-loop hence
the fix is just to return ret at the end of the function to return the
success 0 or -EBUSY return code.

Addresses-Coverity: ("Unused value")
Fixes: d484c21bacfa ("iio: adc: Add driver for Renesas RZ/G2L A/D converter")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iio/adc/rzg2l_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
index 9996d5eef289..868b183e75ea 100644
--- a/drivers/iio/adc/rzg2l_adc.c
+++ b/drivers/iio/adc/rzg2l_adc.c
@@ -401,7 +401,7 @@ static int rzg2l_adc_hw_init(struct rzg2l_adc *adc)
 exit_hw_init:
 	clk_disable_unprepare(adc->pclk);
 
-	return 0;
+	return ret;
 }
 
 static void rzg2l_adc_pm_runtime_disable(void *data)
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-29 16:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 17:21 [PATCH][next] iio: adc: Fix -EBUSY timeout error return Colin King
2021-08-18 15:50 ` Prabhakar Mahadev Lad
2021-08-19 17:20   ` Andy Shevchenko
2021-08-19 17:39     ` Lad, Prabhakar
2021-08-29 17:01       ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).