LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage
@ 2021-08-17 17:47 Rob Herring
  2021-08-17 20:27 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2021-08-17 17:47 UTC (permalink / raw)
  To: devicetree; +Cc: linux-kernel, Bjorn Helgaas, Linus Walleij, linux-pci

The 'contains' keyword applies to elements within an array, so
using 'items' only makes sense if the elements of the array are another
array which is not the case for 'compatible' properties.

Looking at the driver, it seems the intent was the condition should be
true when 'faraday,ftpci100' is present, so we can drop
'cortina,gemini-pci'.

Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML")
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
index fb32f7b55035..92efbf0f1297 100644
--- a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
+++ b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
@@ -113,9 +113,7 @@ if:
   properties:
     compatible:
       contains:
-        items:
-          - const: cortina,gemini-pci
-          - const: faraday,ftpci100
+        const: faraday,ftpci100
 then:
   required:
     - interrupt-controller
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage
  2021-08-17 17:47 [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage Rob Herring
@ 2021-08-17 20:27 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-08-17 20:27 UTC (permalink / raw)
  To: Rob Herring
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, Bjorn Helgaas, linux-pci

On Tue, Aug 17, 2021 at 7:47 PM Rob Herring <robh@kernel.org> wrote:

> The 'contains' keyword applies to elements within an array, so
> using 'items' only makes sense if the elements of the array are another
> array which is not the case for 'compatible' properties.
>
> Looking at the driver, it seems the intent was the condition should be
> true when 'faraday,ftpci100' is present, so we can drop
> 'cortina,gemini-pci'.
>
> Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML")
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-17 20:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 17:47 [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage Rob Herring
2021-08-17 20:27 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).