LKML Archive on
help / color / mirror / Atom feed
From: Saravana Kannan <>
To: Andrew Lunn <>,
	Heiner Kallweit <>,
	Russell King <>,
	"David S. Miller" <>,
	Jakub Kicinski <>
Cc: Saravana Kannan <>,
	Marc Zyngier <>,
	Neil Armstrong <>,
	Kevin Hilman <>,,,
Subject: [PATCH net v2 0/3] Clean up and fix error handling in mdio_mux_init()
Date: Tue, 17 Aug 2021 11:08:38 -0700	[thread overview]
Message-ID: <> (raw)

This patch series was started due to -EPROBE_DEFER not being handled
correctly in mdio_mux_init() and causing issues [1]. While at it, I also
did some more error handling fixes and clean ups. The -EPROBE_DEFER fix is
the last patch.

Ideally, in the last patch we'd treat any error similar to -EPROBE_DEFER
but I'm not sure if it'll break any board/platforms where some child
mdiobus never successfully registers. If we treated all errors similar to
-EPROBE_DEFER, then none of the child mdiobus will work and that might be a
regression. If people are sure this is not a real case, then I can fix up
the last patch to always fail the entire mdio-mux init if any of the child
mdiobus registration fails.

Cc: Marc Zyngier <>
Cc: Neil Armstrong <>
Cc: Kevin Hilman <>
[1] -

v1 -> v2:
- Added Acked-by, Tested-by and Reviewed-by
- Fixing the subject so it goes to "net" tree

Saravana Kannan (3):
  net: mdio-mux: Delete unnecessary devm_kfree
  net: mdio-mux: Don't ignore memory allocation errors
  net: mdio-mux: Handle -EPROBE_DEFER correctly

 drivers/net/mdio/mdio-mux.c | 37 ++++++++++++++++++++++++-------------
 1 file changed, 24 insertions(+), 13 deletions(-)


             reply	other threads:[~2021-08-17 18:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 18:08 Saravana Kannan [this message]
2021-08-17 18:08 ` [PATCH net v2 1/3] net: mdio-mux: Delete unnecessary devm_kfree Saravana Kannan
2021-08-17 21:10   ` Andrew Lunn
2021-08-18  2:56     ` Saravana Kannan
2021-08-18 18:46       ` Andrew Lunn
2021-08-17 18:08 ` [PATCH net v2 2/3] net: mdio-mux: Don't ignore memory allocation errors Saravana Kannan
2021-08-17 18:08 ` [PATCH net v2 3/3] net: mdio-mux: Handle -EPROBE_DEFER correctly Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net v2 0/3] Clean up and fix error handling in mdio_mux_init()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).