From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDAEC432BE for ; Tue, 17 Aug 2021 16:49:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22E4C60EBC for ; Tue, 17 Aug 2021 16:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbhHQQt5 convert rfc822-to-8bit (ORCPT ); Tue, 17 Aug 2021 12:49:57 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:10093 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbhHQQtw (ORCPT ); Tue, 17 Aug 2021 12:49:52 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5921B240008; Tue, 17 Aug 2021 16:49:14 +0000 (UTC) Date: Tue, 17 Aug 2021 18:49:13 +0200 From: Miquel Raynal To: Ezequiel Garcia Cc: Ezequiel Garcia , linux-mtd , Linux Kernel Mailing List , Richard Weinberger , Vignesh Raghavendra Subject: Re: [PATCH 3/3] mtdblock: Warn if the added for a NAND device Message-ID: <20210817184913.5162b242@xps13> In-Reply-To: References: <20210801234509.18774-8-ezequiel@collabora.com> <20210806200537.394260-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ezequiel, Ezequiel Garcia wrote on Tue, 17 Aug 2021 13:27:54 -0300: > Bonjour Miquel, > > On Fri, 6 Aug 2021 at 17:05, Miquel Raynal wrote: > > > > On Sun, 2021-08-01 at 23:45:09 UTC, Ezequiel Garcia wrote: > > > There is a surprisingly large number of tutorials > > > that suggest using mtdblock to mount SquashFS filesystems > > > on flash devices, including NAND devices. > > > > > > This approach is suboptimal than using UBI. If the flash device > > > is NAND, this is specially true, due to wear leveling, bit-flips and > > > badblocks. In this case UBI is strongly preferred, so be nice to users > > > and print a warning suggesting to consider UBI block, if mtdblock > > > is added for a NAND device. > > > > > > Signed-off-by: Ezequiel Garcia > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. > > > > Any chance you respin this one? > > It appears somehow this made its way to the patch: > "Untracked files not listed" sorry about that -- could you remove it? Yeah no problem about that, it happens ;) > While there, you can fix the typo in the commit title: > "mtdblock: Warn if the added for a NAND device" -> "mtdblock: Warn if > added for a NAND device" Done as well. Cheers! Miquèl