LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
liam.r.girdwood@linux.intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
sound-open-firmware@alsa-project.org (moderated list:SOUND -
SOUND OPEN FIRMWARE (SOF) DRIVERS)
Subject: [RFC PATCH 2/2] ASoC: SOF: trigger re-probing of deferred devices from workqueue
Date: Tue, 17 Aug 2021 14:00:57 -0500 [thread overview]
Message-ID: <20210817190057.255264-3-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210817190057.255264-1-pierre-louis.bossart@linux.intel.com>
Audio drivers such as HDaudio legacy and SOF rely on a workqueue to
split the probe into two, with a first pass returning success
immediately, and the second pass taking a lot more time due to the use
of request_module() and the DSP initializations.
This workqueue-based solution helps deal with conflicting requirements
a) other drivers should not be blocked by a long probe
b) a PROBE_PREFER_ASYNCHRONOUS probe_type is explicitly not allowed
to avoid a deadlock when request_module() is used.
This patch makes sure the deferred probe framework is triggered when
the provider of resources successfully completes its initialization.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/sof/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c
index 3e4dd4a86363..cecc0e914807 100644
--- a/sound/soc/sof/core.c
+++ b/sound/soc/sof/core.c
@@ -251,6 +251,9 @@ static int sof_probe_continue(struct snd_sof_dev *sdev)
sdev->probe_completed = true;
+ /* kick-off re-probing of deferred devices */
+ driver_deferred_probe_trigger();
+
return 0;
fw_trace_err:
--
2.25.1
next prev parent reply other threads:[~2021-08-17 19:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 19:00 [RFC PATCH 0/2] driver core: kick deferred probe from delayed context Pierre-Louis Bossart
2021-08-17 19:00 ` [RFC PATCH 1/2] driver core: export driver_deferred_probe_trigger() Pierre-Louis Bossart
2021-08-18 5:44 ` Greg Kroah-Hartman
2021-08-18 11:57 ` Mark Brown
2021-08-18 13:22 ` Greg Kroah-Hartman
2021-08-18 13:48 ` Mark Brown
2021-08-18 14:51 ` Pierre-Louis Bossart
2021-08-18 14:59 ` Dan Williams
2021-08-18 15:28 ` Greg Kroah-Hartman
2021-08-18 15:53 ` Pierre-Louis Bossart
2021-08-18 16:49 ` Greg Kroah-Hartman
2021-08-18 17:52 ` Mark Brown
2021-08-18 18:09 ` Pierre-Louis Bossart
2021-08-18 18:28 ` Mark Brown
2021-08-17 19:00 ` Pierre-Louis Bossart [this message]
2021-08-18 12:07 ` [RFC PATCH 2/2] ASoC: SOF: trigger re-probing of deferred devices from workqueue Mark Brown
2021-08-18 15:25 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817190057.255264-3-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--subject='Re: [RFC PATCH 2/2] ASoC: SOF: trigger re-probing of deferred devices from workqueue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).