LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
@ 2021-08-18  7:02 Michal Vokáč
  2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Michal Vokáč @ 2021-08-18  7:02 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Pavel Machek,
	Jacek Anaszewski, devicetree, linux-kernel,
	Michal Vokáč,
	stable, linux-leds

Since the LED multicolor framework support was added in commit
92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
LEDs on this platform stopped working.

Author of the framework attempted to accommodate this DT to the
framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
to the lp5562 channel node") but that is not sufficient. A color property
is now required even if the multicolor framework is not used, otherwise
the driver probe fails:

  lp5562: probe of 1-0030 failed with error -22

Add the color property to fix this.

Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
Cc: <stable@vger.kernel.org>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index 7d2c72562c73..8c796551352b 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -5,6 +5,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pwm/pwm.h>
 
 / {
@@ -271,6 +272,7 @@ chan@0 {
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
 			reg = <0>;
+			color = <LED_COLOR_ID_RED>;
 		};
 
 		chan@1 {
@@ -278,6 +280,7 @@ chan@1 {
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
 			reg = <1>;
+			color = <LED_COLOR_ID_GREEN>;
 		};
 
 		chan@2 {
@@ -285,6 +288,7 @@ chan@2 {
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
 			reg = <2>;
+			color = <LED_COLOR_ID_BLUE>;
 		};
 
 		chan@3 {
@@ -292,6 +296,7 @@ chan@3 {
 			led-cur = /bits/ 8 <0x0>;
 			max-cur = /bits/ 8 <0x0>;
 			reg = <3>;
+			color = <LED_COLOR_ID_WHITE>;
 		};
 	};
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel
  2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
@ 2021-08-18  7:02 ` Michal Vokáč
  2021-08-18  7:09   ` Pavel Machek
  2021-09-13 13:03   ` Fabio Estevam
  2021-08-18  7:08 ` [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Pavel Machek
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 8+ messages in thread
From: Michal Vokáč @ 2021-08-18  7:02 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Pavel Machek,
	Jacek Anaszewski, devicetree, linux-kernel,
	Michal Vokáč

Since the reg property was added to each channel node in commit
b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562
channel node") it is possible to skip unused channels.

Remove the actually unused white LED channel.

Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index 8c796551352b..3107bf7fbce5 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -290,14 +290,6 @@ chan@2 {
 			reg = <2>;
 			color = <LED_COLOR_ID_BLUE>;
 		};
-
-		chan@3 {
-			chan-name = "W";
-			led-cur = /bits/ 8 <0x0>;
-			max-cur = /bits/ 8 <0x0>;
-			reg = <3>;
-			color = <LED_COLOR_ID_WHITE>;
-		};
 	};
 
 	eeprom@57 {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
  2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
  2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
@ 2021-08-18  7:08 ` Pavel Machek
  2021-09-13 11:20 ` Michal Vokáč
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2021-08-18  7:08 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Shawn Guo, Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Jacek Anaszewski,
	devicetree, linux-kernel, stable, linux-leds

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Wed 2021-08-18 09:02:08, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
> 
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
> 
>   lp5562: probe of 1-0030 failed with error -22
> 
> Add the color property to fix this.
> 
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Cc: <stable@vger.kernel.org>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel
  2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
@ 2021-08-18  7:09   ` Pavel Machek
  2021-09-13 13:03   ` Fabio Estevam
  1 sibling, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2021-08-18  7:09 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Shawn Guo, Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Jacek Anaszewski,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Wed 2021-08-18 09:02:09, Michal Vokáč wrote:
> Since the reg property was added to each channel node in commit
> b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562
> channel node") it is possible to skip unused channels.
> 
> Remove the actually unused white LED channel.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
  2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
  2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
  2021-08-18  7:08 ` [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Pavel Machek
@ 2021-09-13 11:20 ` Michal Vokáč
  2021-09-13 13:03 ` Fabio Estevam
  2021-09-22  3:10 ` Shawn Guo
  4 siblings, 0 replies; 8+ messages in thread
From: Michal Vokáč @ 2021-09-13 11:20 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Pavel Machek,
	Jacek Anaszewski, devicetree, linux-kernel, stable, linux-leds

On 18. 08. 21 9:02, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
> 
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
> 
>    lp5562: probe of 1-0030 failed with error -22
> 
> Add the color property to fix this.
> 
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Cc: <stable@vger.kernel.org>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Hi Shawn,
gentle ping on this little series.

Thank you,
Michal

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
  2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
                   ` (2 preceding siblings ...)
  2021-09-13 11:20 ` Michal Vokáč
@ 2021-09-13 13:03 ` Fabio Estevam
  2021-09-22  3:10 ` Shawn Guo
  4 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2021-09-13 13:03 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Shawn Guo, Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	NXP Linux Team, Pavel Machek, Jacek Anaszewski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, stable, Linux LED Subsystem

Hi Michal,

On Wed, Aug 18, 2021 at 4:02 AM Michal Vokáč <michal.vokac@ysoft.com> wrote:
>
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
>
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
>
>   lp5562: probe of 1-0030 failed with error -22
>
> Add the color property to fix this.
>
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Cc: <stable@vger.kernel.org>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel
  2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
  2021-08-18  7:09   ` Pavel Machek
@ 2021-09-13 13:03   ` Fabio Estevam
  1 sibling, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2021-09-13 13:03 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Shawn Guo, Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	NXP Linux Team, Pavel Machek, Jacek Anaszewski,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

On Wed, Aug 18, 2021 at 4:02 AM Michal Vokáč <michal.vokac@ysoft.com> wrote:
>
> Since the reg property was added to each channel node in commit
> b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562
> channel node") it is possible to skip unused channels.
>
> Remove the actually unused white LED channel.
>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
  2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
                   ` (3 preceding siblings ...)
  2021-09-13 13:03 ` Fabio Estevam
@ 2021-09-22  3:10 ` Shawn Guo
  4 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2021-09-22  3:10 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Rob Herring, Fabio Estevam, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Pavel Machek,
	Jacek Anaszewski, devicetree, linux-kernel, stable, linux-leds

On Wed, Aug 18, 2021 at 09:02:08AM +0200, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
> 
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
> 
>   lp5562: probe of 1-0030 failed with error -22
> 
> Add the color property to fix this.
> 
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Cc: <stable@vger.kernel.org>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Applied both, thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-22  3:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18  7:02 [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Michal Vokáč
2021-08-18  7:02 ` [PATCH 2/2] ARM: dts: imx6dl-yapp4: Remove the unused white LED channel Michal Vokáč
2021-08-18  7:09   ` Pavel Machek
2021-09-13 13:03   ` Fabio Estevam
2021-08-18  7:08 ` [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Pavel Machek
2021-09-13 11:20 ` Michal Vokáč
2021-09-13 13:03 ` Fabio Estevam
2021-09-22  3:10 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).