LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] selftests/bpf: enlarge timeout to 3 seconds for test_maps
@ 2021-08-18  7:16 Li Zhijian
  2021-08-18 10:15 ` lizhijian
  0 siblings, 1 reply; 2+ messages in thread
From: Li Zhijian @ 2021-08-18  7:16 UTC (permalink / raw)
  To: shuah, linux-kselftest, netdev, bpf
  Cc: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
	kpsingh, linux-kernel, philip.li, yifeix.zhu, Li Zhijian,
	kernel test robot

0Day robot observed that it's easily timeout on a heavy load host.
-------------------
 # selftests: bpf: test_maps
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 100 tasks to 'test_hashmap'
 # Fork 100 tasks to 'test_hashmap_percpu'
 # Fork 100 tasks to 'test_hashmap_sizes'
 # Fork 100 tasks to 'test_hashmap_walk'
 # Fork 100 tasks to 'test_arraymap'
 # Fork 100 tasks to 'test_arraymap_percpu'
 # Failed sockmap unexpected timeout
 not ok 3 selftests: bpf: test_maps # exit=1
 # selftests: bpf: test_lru_map
 # nr_cpus:8
-------------------
Since this test will be scheduled by 0Day to a random host that could have
only a few cpus(2-8), enlarge the timeout to avoid a false NG report.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 tools/testing/selftests/bpf/test_maps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index 30cbf5d98f7d..72673e0428fd 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -985,7 +985,7 @@ static void test_sockmap(unsigned int tasks, void *data)
 
 		FD_ZERO(&w);
 		FD_SET(sfd[3], &w);
-		to.tv_sec = 1;
+		to.tv_sec = 3;
 		to.tv_usec = 0;
 		s = select(sfd[3] + 1, &w, NULL, NULL, &to);
 		if (s == -1) {
-- 
2.32.0




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests/bpf: enlarge timeout to 3 seconds for test_maps
  2021-08-18  7:16 [PATCH] selftests/bpf: enlarge timeout to 3 seconds for test_maps Li Zhijian
@ 2021-08-18 10:15 ` lizhijian
  0 siblings, 0 replies; 2+ messages in thread
From: lizhijian @ 2021-08-18 10:15 UTC (permalink / raw)
  To: lizhijian, shuah, linux-kselftest, netdev, bpf
  Cc: ast, daniel, andrii, kafai, songliubraving, yhs, kpsingh,
	linux-kernel, philip.li, yifeix.zhu, kernel test robot


Just noticed that 3 seconds is not enough sometimes, i'm trying to update to 10 seconds instead.

If 10 seconds works, i will send V2 to do that.

Thanks
Zhijian


On 18/08/2021 15:16, Li Zhijian wrote:
> 0Day robot observed that it's easily timeout on a heavy load host.
> -------------------
>   # selftests: bpf: test_maps
>   # Fork 1024 tasks to 'test_update_delete'
>   # Fork 1024 tasks to 'test_update_delete'
>   # Fork 100 tasks to 'test_hashmap'
>   # Fork 100 tasks to 'test_hashmap_percpu'
>   # Fork 100 tasks to 'test_hashmap_sizes'
>   # Fork 100 tasks to 'test_hashmap_walk'
>   # Fork 100 tasks to 'test_arraymap'
>   # Fork 100 tasks to 'test_arraymap_percpu'
>   # Failed sockmap unexpected timeout
>   not ok 3 selftests: bpf: test_maps # exit=1
>   # selftests: bpf: test_lru_map
>   # nr_cpus:8
> -------------------
> Since this test will be scheduled by 0Day to a random host that could have
> only a few cpus(2-8), enlarge the timeout to avoid a false NG report.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>   tools/testing/selftests/bpf/test_maps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
> index 30cbf5d98f7d..72673e0428fd 100644
> --- a/tools/testing/selftests/bpf/test_maps.c
> +++ b/tools/testing/selftests/bpf/test_maps.c
> @@ -985,7 +985,7 @@ static void test_sockmap(unsigned int tasks, void *data)
>   
>   		FD_ZERO(&w);
>   		FD_SET(sfd[3], &w);
> -		to.tv_sec = 1;
> +		to.tv_sec = 3;
>   		to.tv_usec = 0;
>   		s = select(sfd[3] + 1, &w, NULL, NULL, &to);
>   		if (s == -1) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-18 10:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18  7:16 [PATCH] selftests/bpf: enlarge timeout to 3 seconds for test_maps Li Zhijian
2021-08-18 10:15 ` lizhijian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).