LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kari Argillander <kari.argillander@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH v3 1/3] fs/ntfs3: Fix one none utf8 char in source file
Date: Wed, 18 Aug 2021 11:56:23 +0300	[thread overview]
Message-ID: <20210818085623.quzdiekdg2y2vj7n@kari-VirtualBox> (raw)
In-Reply-To: <20210818053300.GA9165@lst.de>

On Wed, Aug 18, 2021 at 07:33:00AM +0200, Christoph Hellwig wrote:
> On Wed, Aug 18, 2021 at 04:06:47AM +0300, Kari Argillander wrote:
> > In one source file there is for some reason non utf8 char. But hey this
> > is fs development so this kind of thing might happen.
> 
> Pleaese also refomat these comments while you're at it.  While going
> over 80 characters is ok in exceptions for readability that is per
> definition never the case for a block comment.

Yeah. Totally good option. I already did it and looks lot better.

On Wed, Aug 18, 2021 at 07:23:40AM +0200, Christoph Hellwig wrote:
> On Wed, Aug 18, 2021 at 04:06:46AM +0300, Kari Argillander wrote:
> > In ntfs3 driver there is allocation made like this ntfs_malloc().
> > Patch 2/3 will converter these to kernel ones like kmalloc(). After I
> > did this then checkpatch raise warnings about array allocations so I
> > fix these in patch 3/3.
> > 
> > I also notice when I made patch that there is broken utf8 char so I
> > wanted first fix that because it raised some warning in my editor and
> > did not want to "break" patch 2/3. So patch 1/3 address that. I did
> > try to apply this and it seem to work without issues.
> 
> So this mostly looks sensible, but I still haven't actually seen
> the codebase this applies to posted anywhere as far as I can tell.

Yeah that's true. Only place for mention this is here (link). I have
asked that Konstantin will send patch series v28 to mailing lists. I
will resist resending v4 before Konstantin has sended.
https://lore.kernel.org/ntfs3/a9114805f777461eac6fbb0e8e5c46f6@paragon-software.com/

  reply	other threads:[~2021-08-18  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  1:06 [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Kari Argillander
2021-08-18  1:06 ` [PATCH v3 1/3] fs/ntfs3: Fix one none utf8 char in source file Kari Argillander
2021-08-18  5:33   ` Christoph Hellwig
2021-08-18  8:56     ` Kari Argillander [this message]
2021-08-18  1:06 ` [PATCH v3 2/3] fs/ntfs3: Do not use driver own alloc wrappers Kari Argillander
2021-08-24  8:04   ` Christoph Hellwig
2021-08-18  1:06 ` [PATCH v3 3/3] fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc Kari Argillander
2021-08-24  8:04   ` Christoph Hellwig
2021-08-18  5:23 ` [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818085623.quzdiekdg2y2vj7n@kari-VirtualBox \
    --to=kari.argillander@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=hch@lst.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --subject='Re: [PATCH v3 1/3] fs/ntfs3: Fix one none utf8 char in source file' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).