LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt-bindings: memory: convert H8/300 bus controller to dtschema
@ 2021-08-18 11:33 Krzysztof Kozlowski
  2021-08-18 18:55 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-18 11:33 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Yoshinori Sato, linux-kernel,
	devicetree

Convert H8/300 bus controller bindings to DT schema format using
json-schema.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../memory-controllers/renesas,h8300-bsc.txt  | 12 -------
 .../memory-controllers/renesas,h8300-bsc.yaml | 35 +++++++++++++++++++
 2 files changed, 35 insertions(+), 12 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml

diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
deleted file mode 100644
index cdf406c902e2..000000000000
--- a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-* H8/300 bus controller
-
-Required properties:
-  - compatible: Must be "renesas,h8300-bsc".
-  - reg: Base address and length of BSC registers.
-
-Example.
-	bsc: memory-controller@fee01e {
-		compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
-		reg = <0xfee01e 8>;
-	};
-
diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
new file mode 100644
index 000000000000..70487bb685cb
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/renesas,h8300-bsc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: H8/300 bus controller
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+  - Yoshinori Sato <ysato@users.sourceforge.jp>
+
+properties:
+  compatible:
+    oneOf:
+      - const: renesas,h8300-bsc
+      - items:
+          - const: renesas,h8300h-bsc
+          - const: renesas,h8300-bsc
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    memory-controller@fee01e {
+        compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
+        reg = <0xfee01e 8>;
+    };
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: memory: convert H8/300 bus controller to dtschema
  2021-08-18 11:33 [PATCH] dt-bindings: memory: convert H8/300 bus controller to dtschema Krzysztof Kozlowski
@ 2021-08-18 18:55 ` Rob Herring
  2021-08-18 20:22   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-08-18 18:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: Yoshinori Sato, linux-kernel, devicetree

On Wed, Aug 18, 2021 at 01:33:25PM +0200, Krzysztof Kozlowski wrote:
> Convert H8/300 bus controller bindings to DT schema format using
> json-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../memory-controllers/renesas,h8300-bsc.txt  | 12 -------
>  .../memory-controllers/renesas,h8300-bsc.yaml | 35 +++++++++++++++++++
>  2 files changed, 35 insertions(+), 12 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
> deleted file mode 100644
> index cdf406c902e2..000000000000
> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -* H8/300 bus controller
> -
> -Required properties:
> -  - compatible: Must be "renesas,h8300-bsc".
> -  - reg: Base address and length of BSC registers.
> -
> -Example.
> -	bsc: memory-controller@fee01e {
> -		compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
> -		reg = <0xfee01e 8>;
> -	};
> -
> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
> new file mode 100644
> index 000000000000..70487bb685cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/renesas,h8300-bsc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: H8/300 bus controller
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +  - Yoshinori Sato <ysato@users.sourceforge.jp>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: renesas,h8300-bsc
> +      - items:
> +          - const: renesas,h8300h-bsc
> +          - const: renesas,h8300-bsc

Seems what's actually in use is:

items:
  - enum: 
      - renesas,h8300h-bsc
      - renesas,h8s-bsc
  - const: renesas,h8300-bsc

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: memory: convert H8/300 bus controller to dtschema
  2021-08-18 18:55 ` Rob Herring
@ 2021-08-18 20:22   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-18 20:22 UTC (permalink / raw)
  To: Rob Herring; +Cc: Yoshinori Sato, linux-kernel, devicetree

On 18/08/2021 20:55, Rob Herring wrote:
> On Wed, Aug 18, 2021 at 01:33:25PM +0200, Krzysztof Kozlowski wrote:
>> Convert H8/300 bus controller bindings to DT schema format using
>> json-schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>  .../memory-controllers/renesas,h8300-bsc.txt  | 12 -------
>>  .../memory-controllers/renesas,h8300-bsc.yaml | 35 +++++++++++++++++++
>>  2 files changed, 35 insertions(+), 12 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
>>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
>> deleted file mode 100644
>> index cdf406c902e2..000000000000
>> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt
>> +++ /dev/null
>> @@ -1,12 +0,0 @@
>> -* H8/300 bus controller
>> -
>> -Required properties:
>> -  - compatible: Must be "renesas,h8300-bsc".
>> -  - reg: Base address and length of BSC registers.
>> -
>> -Example.
>> -	bsc: memory-controller@fee01e {
>> -		compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
>> -		reg = <0xfee01e 8>;
>> -	};
>> -
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
>> new file mode 100644
>> index 000000000000..70487bb685cb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.yaml
>> @@ -0,0 +1,35 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/memory-controllers/renesas,h8300-bsc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: H8/300 bus controller
>> +
>> +maintainers:
>> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> +  - Yoshinori Sato <ysato@users.sourceforge.jp>
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: renesas,h8300-bsc
>> +      - items:
>> +          - const: renesas,h8300h-bsc
>> +          - const: renesas,h8300-bsc
> 
> Seems what's actually in use is:
> 
> items:
>   - enum: 
>       - renesas,h8300h-bsc
>       - renesas,h8s-bsc
>   - const: renesas,h8300-bsc
> 

Indeed, I missed that one more compatible. I will send a v2, thanks for
feedback.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-18 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 11:33 [PATCH] dt-bindings: memory: convert H8/300 bus controller to dtschema Krzysztof Kozlowski
2021-08-18 18:55 ` Rob Herring
2021-08-18 20:22   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).